NPM Resource Changed PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
9 Mar 2026

Pull Request resolves #44407 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Switching the Client filter (Site / Administrator) in the Menu Items view should reset the Menu filter so a valid menu can be selected for the chosen client. This currently fails because the reset logic in SearchTools.clear() only checks fields inside .js-stools-container-filters, while the client_id and menutype selectors are placed inside .js-stools-container-selector. As a result, the dependent filter is not cleared, an invalid combination may be submitted, and Joomla falls back to the Site client. This change includes .js-stools-container-selector in the reset check so the Menu filter is properly cleared when the Client filter changes.

Testing Instructions

Go to Menus and then All Menu Items in the administrator.
Ensure the filters show something like:
Client: Site
Menu: Main Menu
Change the Client filter from Site to Administrator
Repeat the same test in the opposite direction by changing Client from Administrator back to Site.

Actual result BEFORE applying this Pull Request

When changing the Client filter from Site to Administrator, the page reloads but the Client filter reverts back to Site.

Expected result AFTER applying this Pull Request

When switching the Client filter between Site and Administrator, the Menu filter is automatically reset to “Select Menu” before the form is submitted. The page reloads with the correct client selected, and the Menu dropdown then displays only the menus that belong to that client, allowing the user to switch between Site and Administrator menu items correctly.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 9 Mar 2026
avatar adarshdubey03 adarshdubey03 - change - 9 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2026
Category JavaScript Repository NPM Change
avatar brianteeman
brianteeman - comment - 9 Mar 2026

AWESOME - thats a perfect fix

Just one small problem - as this is a bug fix and not a new feature it should be made against the 5.4 branch. You might be able to rebase this PR but often that fails when downgrading so it might be best to close this and just create a new PR on the 5.4 branch with this change

avatar adarshdubey03 adarshdubey03 - change - 10 Mar 2026
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2026-03-10 10:57:57
Closed_By adarshdubey03
Labels Added: NPM Resource Changed PR-6.1-dev
avatar adarshdubey03 adarshdubey03 - close - 10 Mar 2026
avatar adarshdubey03
adarshdubey03 - comment - 10 Mar 2026

I have raised a new pr against 5.4 !!

Add a Comment

Login with GitHub to post a comment