[#47343] - [6.1] php-cs-fixer: Check cassiopeia and atum files
- Pending
- Medium
- Build: 6.1-dev
- # 47343
- Diff
- Hackwar:6.1-php-cs-fixer-1
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This removes the exclusions for the atum and cassiopeia files and fixes the codestyle issues in them.
Testing Instructions
Nothing to test, just codereview.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
I know that. The question is, why we shouldn't apply our rules to all files. But we shouldn't also not discuss this and without a PR, a discussion is useless.
ok so as you asked for a discussion - here's my 2c
While I am all for code consistency etc and it annoys me when I see these issues in the template files it really should also include all the /tmpl/ files but the noise to users on update with a huge list of overrides to check is too big an inconvenience for end users compared to the small annoyance to my desire for following rules and consistency.
@HLeithner said in an unrelated PR the other day something that could work that it would be ok to change them when we are making other changes to the file but not to change them just for the sake of changing
The problem with this is it generates a lot of notices for people for overrides to check. Is it really worth generating that noise for people?