Ready to test, PHPStan error doesn't effect the testing

I have tested this item ✅ successfully on 3d0618b

Installed Multilingual Sample Data
Edited existing modules adding associations
Created new modules and created associated modules on-the-fly (same type)
Created modules of different types and associated them
Edited associated module on-the-fly
Checked Associations component

All worked as described and expected

When installing the multilingual sample data wouldnt it be a good example if the two menu modules were associated

I have tested this item 🔴 unsuccessfully on 3d0618b

video coming soon showing it doesnt work in the com_associations component

Doesnt happen all the time but I keep getting "1615 Prepared statement needs to be re-prepared"

Doesnt happen all the time but I keep getting "1615 Prepared statement needs to be re-prepared"

Never have seen this message. Could you try it with articles or categories? I have my doubts that it has to do with the change I have done.

Or could you enable debugging mode so we can see which query results in this message?

I did some research and people had this problem could solve it with

SET GLOBAL table_definition_cache = 1024

I've never seen this problem before on the same server

I have tested this item ✅ successfully on 3d0618b

Thanks for fixing this.

Tested with JBT

• Installed de-DE and es-ES
• Applied 46671 by Patch Tester and run npm ci
• Installed Multilanguage Data to setup multilanguage site
• Installed zitat-service.de module and created three times Site Module with de-DE, es-ED and en-UK
• Associated one module to the other two, tested frontend is working for the three languages
• Components / Multilingial Associations is working for Modules
• Creating new module is working for associated language (language is set and selection is disabled)
• Different types of modules are working with associations
• Checked Joomla logs and there are no abnormalities
• Saw the problem found by Emmanuel: Administrator modules have 'Associations' tab, but no language selection

Hi @rdeutz, during the PR Testing Group session, Heiko and I were testing your PR, and it seems to work great for what was listed in the Testing Instructions, but in the process of testing I found an issue :/

(I tried to see what would happen with the Administrator Modules and while I expected the Associations Tab NOT to be there, it (the Association Tab) WAS present + some weird additional chrome that I don't think should be there, perhaps a lack of filtering in the code for 'type of Modules'?)

Here is a quick video to show what I found/might be easier to understand that the above comment:

Hope that helps! thanks.

Good spot. You are correct - this functionality needs to exclude admin modules by ensuring that the queries have where client_id=0

@exlemor @muhme good find, I removed the admin module associations possibility

@brianteeman could you explain how you get it,please? From the screenshot it looks as you are hit save for the reference while you haven't added all information for the target.

it happened randomly either when opening the component OR when selecting the target but annoyingly not all the time

@rdeutz - Great fix, the Administrator Modules, no longer appear, but during today's (Saturday) Weekend PR Testing Group session with Krishna, I noticed a different odd issue:

I have a Main menu fr-FR site module and a Main menu en-GB site module, each assigned to their respective language with each having 2-3 menu entries - each having a Home entry, each assigned to sidebar-right, each set to Public, assigned to On All Pages and being identically configured in every respect except their language. I have associated one to the other.

The Main menu en-GB shows up as expected the Main menu fr-FR does not! 😱😭

( Let me know if you need a video, I can do one later, but at the moment, I am in a noisy café ;( )

The reason that the menu is not visible is a result of change in 6.1 #46603. I will discuss with the maintainers what is the best way to fix this.

@exlemor I fixed it here too

@exlemor I fixed it here too

@rdeutz - well, it's getting better :) but 1 thing got fixed, 1 thing got broken :/

I updated to the newest package... and now:
the Main menu en-FR is SHOWING - victory 🎆
the Main menu en-GB only has 1 line/entry (Home) and doesn't have:
Template Settings
Select Category List for PR 46539

(yet I changed nothing since my previous testing).

Main menu en-GB (lost 2 entries). 😭

Main menu en-FR now SHOWING 😃 (exactly what it should)

I am waiting to get #46710 merged and then we can test again @exlemor

@rdeutz tested again and no longer get the prepared statement issue. weird as nothing has changed but lets put it down to unrelated to this pr

@exlemor I kind of merged the PR from Fedir into my PR and now I can see all menu items. I guess you had menuitem set to Language "All". I forget to handle this situation, but Fedir did a better job so I use his solution.

@brianteeman thanks for retesting.

it would be good if we had some cypress tests for this BUT i see that we dont have any at the moment for com_associations

I have tested this item ✅ successfully on fdb60da

I have successfully tested this now. Thanks @rdeutz for the fixes (sorry that I made you update it so many times).

I tested same module to same module in 2 different languages in the same Position and it worked well,
I tested same module in 2 different languages in different positions with different Access Levels and they showed up correctly,
I tested 1 module of 1 type in 1 position and another module of another type in a different position with different access levels and the associations all worked ! :)
I tested 1 module of 1 type in 1 position in 1 language, another module of another type in a different position in another, and a 3rd module of yet another type in a different position and access levels... ALL worked! :)

RTC

I have tested this item ✅ successfully on 9aef3d7

Tested with JBT

• Installed de-DE, es-ES, ja-JP and uk-UA language packages by install extension
• Applied 46671 by Patch Tester and npm ci
• Installed Multilanguage Data to setup multilanguage site
• Edited the five Categories menu items 'display in menu' to have a second menu entry
• Installed zitat-service.de module one time, configured for Language en-GB and quote en
• ✅ Created four times associated module in the other four languages by Create
  • Status 'Published' and Menu Assignment 'On all pages' is copied, but not the Position (in this case 'sidebar-right')
    • ¿ Is it useful/practical to copy the position as well if we create an associated website module?
  • Quotes in the five different languages are shown in the frontend
• ✅ Existing and new Administrator modules have no associations
• ✅ Created Custom site module and it is possible to associate a different module type
• ✅ Checked Components > Multilingual Associations
  • Side by side views are working
  • Modifications in reference view are saved
  • Modifications in target view are saved
    • Even inside the side-by-side view we have the Associatens tab with the ability to edit
      • ¿ Perhaps less confusing to omit the Associatens tab in the site-by-site view?
• ✅ Checked Joomla logs and there are no abnormalities

Even inside the side-by-side view we have the Associatens tab with the ability to edit
¿ Perhaps less confusing to omit the Associatens tab in the site-by-site view?

I agree that can confuse people, but as it is the same as for other associations I would say that's outsite of the scope of this PR. We should fix it with another PR.

Thanks.

And I hope you be able to write the documentation soon.