[#46567] - Fix frontend editing module menu regex
- Closed
- 12 Dec 2025
- Medium
- Build: 5.4-dev
- # 46567
- Diff
- henrikdalgaard:fix-frontediting-mod-menu-regex
User tests: Successful: Unsuccessful:
Pull Request for Issue #46566 .
Summary of Changes
The regex which finds the menu item links is too loose and can match outside the li tag. This resulted in double edit link icons on my joomla 6 site.
I added a space between the edit link and the menu item as it looks better in my opinion.
Visual view of buggy and fixed menu.
Testing Instructions
Enable front end editing on a decently filled menu.
Notice a some double edit links to unintended content.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL |
@henrikdalgaard It seems you have chosen the wrong target branch for your PR, or your PR is based on the wrong branch. The PR seems to be based on a 6.1-dev branch, but it is made for the target branch 5.4-dev, that does not fit together. If you check it on GitHub you will see lots of unrelated changes because you see all changes from 6.1-dev compared to 5.4-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-12-12 22:30:44 |
| Closed_By | ⇒ | henrikdalgaard | |
| Labels |
Added:
PR-5.4-dev
|
||
made on version 6.0.1 - not 5.4
This is my first PR to Joomla. It has bugged me on a site I help manage, and I decided to dig in and find the problem