[#46568] - tightened regex searching for menu items
- Closed
- 12 Dec 2025
- Medium
- Build: 5.4-dev
- # 46568
- Diff
- henrikdalgaard:5.4-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #46567 .
Summary of Changes
The regex search and replace for menu items finds too many matches as the regex is not limited to one li tag. This results in extra edit links getting added. See screen shots.
An extra space is added to after the inserted edit link as it looks bad if flush against the menu item.
Tabs replaced with spaces in the same line.
Testing Instructions
Enable frontend editing on a page with a menu with lots of items.
Example buggy html output with fixed html
mod-menu1-buggy.html
mod-menu1-fixed.html
Actual result BEFORE applying this Pull Request
See screen shot - notice the extra edit buttons which links to a different page
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-12-12 23:45:30 |
| Closed_By | ⇒ | henrikdalgaard | |
| Labels |
Added:
PR-5.4-dev
|
||
too tired - withdrawing my pr