NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
8 Dec 2025

Summary of Changes

After #45352 is merged, more issues with the menu can be fixed. This PR now fixes two issues:

  • When there are more than two levels of menu items in the backend, the deeper levels has no correct padding
  • When one of the sub-levels are opened there is a JS error and after refreshing the page the menu does not stay open

Testing Instructions

This is a bit tricky, as we have to kind of fake a deep hierarchy in the backend. So either create your own custom backend menu or we use a little trick to inject a deeper hierachy:

  • Open administrator/modules/mod_menu/src/Menu/CssMenu.php
  • Add the following code after line 423:
elseif ($item->element === 'com_contact' && isset($query['view']) && $query['view'] === 'contacts') {
    MenusHelper::loadPreset('content', false, $item);
}

This will load the content menu below the com_contact menu.

Actual result BEFORE applying this Pull Request

  • When opening the deep hierarchy, a JS error is thrown:
grafik - After refreshing the page, the selected active menu item is not opened - Styling is not correct grafik

Expected result AFTER applying this Pull Request

  • No JS error
  • Active menu item is visible
  • Styling is correct
grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar bembelimen bembelimen - open - 8 Dec 2025
avatar bembelimen bembelimen - change - 8 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2025
Category Modules Administration JavaScript Repository NPM Change
avatar bembelimen bembelimen - change - 8 Dec 2025
Labels Added: NPM Resource Changed PR-6.0-dev
avatar bembelimen bembelimen - change - 8 Dec 2025
The description was changed
avatar bembelimen bembelimen - edited - 8 Dec 2025
avatar exlemor
exlemor - comment - 8 Dec 2025

Hi @bembelimen, I have the BEFORE condition (including the JS console error and incorrect styling), after placing that code after line 423, but I have the standard design for that area and not what you show in your AFTER image - the good news there is NO JS console error which I have in the BEFORE situation once the PR is applied - so I think that I should show you:

ScreenFloat Shot of Safari on 2025-12-08 at 18-48-03
avatar exlemor exlemor - test_item - 8 Dec 2025 - Tested successfully
avatar exlemor
exlemor - comment - 8 Dec 2025

I have tested this item ✅ successfully on 88074e3

I have tested this successfully. Thanks @bembelimen for the work!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46550.

Add a Comment

Login with GitHub to post a comment