[#46549] - [6.1] Refactor SiteApplication language detection
- Fixed in Code Base
- 23 Jan 2026
- Medium
- Build: 6.1-dev
- # 46549
- Diff
- joomdonation:site-application-detect-language
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR improves the initialiseApp() method in SiteApplication by extracting the language-detection logic into a separate method. The logic remains unchanged, but the code is cleaner, reduces nesting, and is easier to maintain.
Testing Instructions
- Uses Joomla 6.1
- Apply patch
- Navigate to random pages from frontend of the site and make sure it is still working as before.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to maintain code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
richard67
- | Title |
|
||||||
| Labels |
Added:
PR-6.1-dev
|
||
I have tested this item ✅ successfully on f283c35
Tested with de-de and en-gb.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.
| Labels |
Added:
RTC
|
||
If tests are successful, it should be automerged, thanks.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-01-23 16:06:16 |
| Closed_By | ⇒ | HLeithner |
I have tested this item ✅ successfully on 5ef954d
Tested on a a 6.1 site with Testing Data and two languages installed. Randomly selected menu items all worked as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.