RTC PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Nov 2025

Pull Request for Issue # .

Summary of Changes

Removes the last use of the deprecated Joomla.JText

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 19 Nov 2025
avatar brianteeman brianteeman - change - 19 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2025
Category Administration com_content
avatar hans2103 hans2103 - test_item - 19 Nov 2025 - Tested successfully
avatar hans2103
hans2103 - comment - 19 Nov 2025

I have tested this item ✅ successfully on a1fc9bf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46469.

avatar tecpromotion tecpromotion - change - 19 Nov 2025
Title
[6.0 Jtext last use
[6.0] Jtext last use
avatar tecpromotion tecpromotion - edited - 19 Nov 2025
avatar laoneo laoneo - test_item - 19 Nov 2025 - Tested successfully
avatar laoneo
laoneo - comment - 19 Nov 2025

I have tested this item ✅ successfully on a1fc9bf

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46469.

avatar QuyTon QuyTon - change - 19 Nov 2025
Status Pending Ready to Commit
Labels Added: PR-6.0-dev
avatar QuyTon
QuyTon - comment - 19 Nov 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46469.

avatar richard67
richard67 - comment - 19 Nov 2025

@brianteeman Again I don't understand why you made this PR for 6.0-dev. As far as I remember I had explained it once:

  • If it is a fix for a bug which affects both 5.4 and 6.x, or if it affects only 5.4, the PR has to be made for 5.4-dev.
  • If it is a fix for a bug which affects only 6.x, the PR has to be made for 6.0-dev.
  • If it is a fix for a bug which affects only 6.1, or if it is not a bug fix but a feature, the PR has to be made for 6.1-dev.

So the only kind of PR to be made for 6.0-dev are bug fixes specific for 6.x.

avatar richard67
richard67 - comment - 19 Nov 2025

P.S.: The same code as the one fixed here also exists in 5.4-dev.

avatar brianteeman
brianteeman - comment - 19 Nov 2025

because originally it was a bigger PR that could only be made in 6.* but brains bigger than mine said it would break things

avatar brianteeman brianteeman - close - 19 Nov 2025
avatar brianteeman brianteeman - change - 19 Nov 2025
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2025-11-19 17:39:25
Closed_By brianteeman
Labels Added: RTC
avatar richard67
richard67 - comment - 19 Nov 2025

@hans2103 @laoneo PR has been remade for 5.4-dev, see #46473 . Could you mark your test result again in that new PR. Thanks in advance.

Add a Comment

Login with GitHub to post a comment