RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
19 Nov 2025

Issue # .

Summary of Changes

Adding a clear guidance to the README.md for contributors on which branch to target when submitting pull requests.
The new section uses a simple classification table to help contributors choose the correct branch based on the type of change.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 19 Nov 2025
avatar LadySolveig LadySolveig - change - 19 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2025
Category Repository
avatar brianteeman
brianteeman - comment - 19 Nov 2025

Shouldn't the same change also be made in readme.txt?

avatar LadySolveig
LadySolveig - comment - 19 Nov 2025

Good question, they are definitely not the same texts, the txt seems to have a few more passages and probably hasn't been updated for a while.

No, sorry, I was wrong, in the 6 branch it is also written on 6 so it is current.

avatar LadySolveig
LadySolveig - comment - 19 Nov 2025

The How to get a working installation from the source section is also not in the txt-file.
I don't think it's the idea that they are identical, but I can't say for sure. I think that since it is primarily intended to make collaboration here on Github easier and transparent, the .md file is definitely not wrong.

avatar chmst chmst - test_item - 19 Nov 2025 - Tested successfully
avatar chmst
chmst - comment - 19 Nov 2025

I have tested this item ✅ successfully on 863fcda

Good Idea.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

avatar dautrich dautrich - test_item - 22 Nov 2025 - Tested successfully
avatar dautrich
dautrich - comment - 22 Nov 2025

I have tested this item ✅ successfully on 863fcda

I agree with Christiane.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

avatar richard67 richard67 - change - 22 Nov 2025
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 22 Nov 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46471.

avatar muhme muhme - change - 26 Nov 2025
Labels Added: RTC
avatar muhme
muhme - comment - 26 Nov 2025

✅ Final check before merging with Codespace – to check the formatting. As discussed, the new section ‘Which branch should my pull request target?’ is not included in ‘readme.txt’ and therefore not in the complete/updated package. It is only visible on GitHub or with git clone. I agree that this is OK, as its primary purpose is to make collaboration on GitHub easier.

avatar muhme muhme - change - 26 Nov 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-11-26 10:58:31
Closed_By muhme
avatar muhme muhme - close - 26 Nov 2025
avatar muhme muhme - merge - 26 Nov 2025
avatar muhme
muhme - comment - 26 Nov 2025

Thank you @LadySolveig for your contribution. Thank you @brianteeman for commenting. Thank you @chmst and @dautrich for testing.

Add a Comment

Login with GitHub to post a comment