This here is a bc break and has to go into 7.0.

how is it a b/c break? we still have this
https://github.com/joomla/joomla-cms/blob/5.4-dev/build/media_source/system/js/core.es6.js#L298-L306

When an extension uses Joomla.getOptions('joomla.jtext'); it will break.

When an extension uses Joomla.getOptions('joomla.jtext'); it will break.

No, it won't. See Brian's remark. Joomla.JText will still be replaced by Joomla.Text (until 7.0).

This PR only replaces the deprecated use of joomla.jtext in the core. We don't need them.

This is something different, as far as I can see it. Does it still return the translation strings when you use Joomla.getOptions('joomla.jtext'); ?

This is something different, as far as I can see it. Does it still return the translation strings when you use Joomla.getOptions('joomla.jtext'); ?

Yes, no problem. Can you explain why it would be a problem, as far as you can see it? 😕

Please keep old key name for script options.

$doc->addScriptOptions('joomla.jtext', $strings, false);
// and 
$doc->getScriptOptions('joomla.jtext')

It will work in the core, as you did, of course .
But when some extension trying to do some fancy thing and accessing these options from PHP then their code will be broken after this changes.

Sorry, didn't look well. This PR is because of some other discussion about deprecated code in the core, but it is only the first change of Joomla.JText._ into Joomla.Text._ that we spoke about. The other changes are something different indeed...

This is something different, as far as I can see it. Does it still return the translation strings when you use Joomla.getOptions('joomla.jtext'); ?

Yes, no problem. Can you explain why it would be a problem, as far as you can see it? 😕

As I said, try it out and you will see it. Without the patch it returns the strings, with it not. This is clearly a bc issue for me.