[#46347] - [6.1] Change color from danger to warning for dashboard override check
- Pending
- Medium
- Build: 6.1-dev
- # 46347
- Diff
- bembelimen:6.1/overrides-changed
User tests: Successful: Unsuccessful:
Summary of Changes
After an update most templates with overrides are marked as "has to be checked" and the dashboard shows a red info icon on the dashboard. Although it's good to check the overrides it not a critical thing to do. Especially many "normal" user are irritated about the red warning color.
This PR softens the color to a "warning".
Testing Instructions
- Install Joomla! 5.3.4 and create an override of a file which was changed in 5.4 (e.g. the com_content article view)
- Update to 5.4 + 6.0 to trigger the "Override(s) to check" message on the dashboard
- Apply path
Actual result BEFORE applying this Pull Request
The message is red
Expected result AFTER applying this Pull Request
The message is yellow
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Red generally signifies something that requires immediate attention and/or is critical and/or an error.
Yellow generally signifies a warning that requires attention, but is not critical. Take note and proceed with caution.
If outdated overrides are critical, then keep it red, else if your site will still function, then yellow would be the better approach.
Does this makes the situation better? I think this feature does more harm then good. Maybe removing it or making it more useful (3-way diff) would be better.