RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
19 Oct 2025

Pull Request for Issue #45536 .

Summary of Changes

Mark already selected elements with checkmark, based on @travisrisner idea

Screenshot 2025-10-19_13-06-56

Testing Instructions

Run npm install

Please follow #45536

Or open Articles list and filter by category (or few).
After filtering check the category filter dropdown. There should be marked already selected items.

Actual result BEFORE applying this Pull Request

Already selected items not marked

Expected result AFTER applying this Pull Request

Already selected items is marked

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 19 Oct 2025
avatar Fedik Fedik - change - 19 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2025
Category Repository NPM Change
avatar Fedik Fedik - change - 19 Oct 2025
The description was changed
avatar Fedik Fedik - edited - 19 Oct 2025
avatar Fedik Fedik - change - 19 Oct 2025
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar brianteeman
brianteeman - comment - 21 Oct 2025

Please use the logical css propery inset-inline-end instead of right or it will not work as intended in an RTL language

right

image

inset-inline-end

image
20d03ae 21 Oct 2025 avatar Fedik inset
avatar Fedik
Fedik - comment - 21 Oct 2025

updated

avatar brianteeman brianteeman - test_item - 21 Oct 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Oct 2025

I have tested this item ✅ successfully on 20d03ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

avatar Fedik Fedik - change - 21 Oct 2025
The description was changed
avatar Fedik Fedik - edited - 21 Oct 2025
avatar travisrisner travisrisner - test_item - 21 Oct 2025 - Tested successfully
avatar travisrisner
travisrisner - comment - 21 Oct 2025

I have tested this item ✅ successfully on 20d03ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

avatar richard67 richard67 - change - 21 Oct 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Oct 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46328.

avatar muhme muhme - change - 21 Oct 2025
Labels Added: RTC
avatar muhme
muhme - comment - 21 Oct 2025

✅ Final test before merge with JBT 5.4-dev

  • Before the PR
    • Installed Testing Sample Data, seen article view in selecting categories is not marking selected categories
  • PR applied with gh pr checkout 46328 and npm ci
  • Selected entries are marked, one and mulitple entries are mark-able, deselecting is working, tested with Firefox, Chrome, Safari and Edge
avatar muhme muhme - change - 21 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-21 15:18:54
Closed_By muhme
avatar muhme muhme - close - 21 Oct 2025
avatar muhme muhme - merge - 21 Oct 2025
avatar muhme
muhme - comment - 21 Oct 2025

Thank you @Fedik for your contribution. Thank you @richard67 and @brianteeman for your support. Thank you @brianteeman and @travisrisner for testing.

Add a Comment

Login with GitHub to post a comment