Joomla! Issue Tracker | Joomla! CMS #46329 - [5.4] WebAsset fix type check to be interface instead of class

bug PR-5.4-dev

Closed
19 Oct 2025
Medium
Build: 5.4-dev
# 46329
Diff
Fedik:webaset-fix-type-interface-instead-class

Pending

User tests: Successful: Unsuccessful:

Fedik
19 Oct 2025

Pull Request for Issue # .

Summary of Changes

Fixing type check to be WebAssetItemInterface instead of hardcoded WebAssetItem class.
Which is allows to use custom classes.

Testing Instructions

Code review by maintainers.

Create dummy class for b/k check:

$test = new class($wa->getRegistry()) extends \Joomla\CMS\WebAsset\WebAssetManager{
    protected function enableDependencies(?string $type = null, ?Joomla\CMS\WebAsset\WebAssetItem $asset = null): self
    {
        return parent::enableDependencies($type, $asset);
    }
    protected function getDependenciesForAsset(
        string $type,
        Joomla\CMS\WebAsset\WebAssetItem $asset,
        $recursively = false,
        ?string $recursionType = null,
        ?Joomla\CMS\WebAsset\WebAssetItem $recursionRoot = null
    ): array {
        return parent::getDependenciesForAsset($type, $asset, $recursionType, $recursionRoot);
    }
};

Actual result BEFORE applying this Pull Request

test class works

Expected result AFTER applying this Pull Request

test class works

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

f1902a6 19 Oct 2025

WebAsset fix type check to be interface instead of class

Fedik - open - 19 Oct 2025

Fedik - change - 19 Oct 2025

Status

New

⇒

Pending

joomla-cms-bot - change - 19 Oct 2025

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#46329] - [5.4] WebAsset fix type check to be interface instead of class