[#46277] - [6.1] Meaningful uninstall message
- Pending
- Medium
- Build: 6.1-dev
- # 46277
- Diff
- brianteeman:uninstall_data
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Include the name of the extension in the successful uninstall message. This is particularly useful when you uninstall multiple extensions at the same time.
Testing Instructions
Uninstall one or more extensions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Language & Strings |
The failing system test is expected. I can fix it if there is interest in this PR
@brianteeman Ir fails at the "can install and uninstall a component from URL tab" test in file tests/System/integration/administrator/components/com_installer/FromUrl.cy because of the changed language string, so fixing it in this PR would be welcome.
Yes I know why it fails and if this pr has any interest I will fix it
| Labels |
Added:
Language Change
PR-6.1-dev
|
||
| Category | Administration com_installer Language & Strings | ⇒ | Administration com_installer Language & Strings JavaScript Unit Tests |
It's been uninstalled so the language string no longer exists
No it is not. It is uninstalled at line 261. Before that it should be possible tor translate, in theory.
However when language files are not loaded you can ignore that suggestion. I cannot check it currently.
If you can get it to work then please submit a pr to this branch. I tried and can not
Okay I checked and it is possible to translate, but it need much more work. Can ignore that suggestion.
But please update UNINSTALL_ERROR message.
You can trigger it by removing the line 261
| Labels |
Added:
Unit/System Tests
|
||
added the name to the uninstall error message
I have tested this item ✅ successfully on 1bc07de
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46277.
The failing system test is expected. I can fix it if there is interest in this PR