[#46196] - [6.0] Fix note custom field deprecated warning
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 46196
- Diff
- TLWebdesign:6.0-dev
User tests: Successful: Unsuccessful:
This PR fixes the issue of the deprecated warning by not removing the default_field but setting it to hidden thru the form params instead.
Pull Request for Issue #46187 .
Summary of Changes
Removed default_value from the remove fields logic in the prepareForm method.
Added the default_value as a hidden field through the note.xml params file.
Testing Instructions
- Turn on error reporting to maximum.
- Create a new note field.
- Open an article that displays this field
Actual result BEFORE applying this Pull Request
Deprecated: DOMCdataSection::__construct(): Passing null to parameter #1 ($data) of type string is deprecated in \administrator\components\com_fields\src\Plugin\FieldsPlugin.php on line 277
Expected result AFTER applying this Pull Request
No Deprecated warnings and default value field is still not visible.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
I have tested this item ✅ successfully on f88b627
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46196.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46196.
I have tested this item ✅ successfully on f88b627
Works! Hiding the default value field is probably the best option to keep things from breaking.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46196.