Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar TLWebdesign
TLWebdesign
30 Sep 2025

Pull Request for Issue #46149 .

Summary of Changes

Added JPAGETITLE language constant to the backend language file.

Testing Instructions

This requires a bit of code changing to test.

First make sure you set this global configuration setting:

  • Site Tab -> Site Name in Page Titles -> to before or after

Then go to this file:

  • administrator/components/com_banners/src/View/Banners/HtmlView.php
    around line 522 add this code:
        $this->setDocumentTitle("TEST PAGE TITLE");

after

        $this->addToolbar();

Now go to this url:
yourdomain.com/administrator/index.php?option=com_banners&view=banners

Or open banners view in your administrator backend.

Actual result BEFORE applying this Pull Request

  • Page title shows JPAGETITLE

Expected result AFTER applying this Pull Request

  • Page title shows "TEST PAGE TITLE" or other name you used in $this->setDocumentTitle("TEST PAGE TITLE");

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

avatar TLWebdesign TLWebdesign - open - 30 Sep 2025
avatar TLWebdesign TLWebdesign - change - 30 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2025
Category Administration Language & Strings
avatar HLeithner
HLeithner - comment - 15 Oct 2025

This pull request has been automatically rebased to 5.4-dev.

avatar richard67 richard67 - change - 17 Oct 2025
Title
Fix for setDocumentTitle missing language string
[5.4] Fix for setDocumentTitle missing language string
avatar richard67 richard67 - edited - 17 Oct 2025
avatar richard67 richard67 - change - 17 Oct 2025
Labels Added: Language Change bug PR-5.4-dev
avatar ceford
ceford - comment - 3 Nov 2025

This PR makes no sense to me. I see no problems in the Banners page. And there are only 209 lines in the file! With the changes made I see Site Name - TEST PAGE TITLE rather than Banners. But why? That seems to be less useful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46197.

avatar TLWebdesign
TLWebdesign - comment - 7 Nov 2025

Then i guess you didn't understand the instructions. That is on me. It's a bit technical but if you don't have the language string in it, the page title is called JPAGETITLE. With this PR it is displaying the title as it should. It is fixing a function available in joomla that now is broken in the backend. But since joomla doesn't use this function in the backend itself you need to edit some code to test it.

avatar TLWebdesign TLWebdesign - change - 10 Nov 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-11-10 19:53:45
Closed_By TLWebdesign
avatar TLWebdesign TLWebdesign - close - 10 Nov 2025
avatar richard67
richard67 - comment - 10 Nov 2025

@TLWebdesign "closed this by deleting the head repository" ... was that an accident or by purpose?

avatar TLWebdesign
TLWebdesign - comment - 10 Nov 2025

Accident of course. i'm so stupid...

Add a Comment

Login with GitHub to post a comment