[#46195] - [5.4] Fix InstallerScript using 'id' instead of 'extension_id' for #__extension
- Fixed in Code Base
- 16 Oct 2025
- Medium
- Build: 5.3-dev
- # 46195
- Diff
- Aaqilyousuf:fix-installer-paramid
User tests: Successful: Unsuccessful:
Pull Request for Issue #46185
Summary of Changes
- Replaced incorrect
'id'column with'extension_id'ingetParam()andsetParams()methods ofInstallerScript. - This ensures extension parameters are correctly retrieved and updated in the
#__extensionstable during installation or updates.
Testing Instructions
-
Install or update an extension that uses `InstallerScript`.
-
In the `script.php`, try to set a parameter:
$this->setParams(\['my\_param' => 'test\_value'\], $extensionId); -
Retrieve the parameter:
$value = $this->getParam('my\_param', $extensionId); -
Verify the value matches in the database (#__extensions table) under params.
-
Before fix, the value would not be set/retrieved correctly. After the fix, it should work as expected.
Actual result BEFORE applying this Pull Request
- setParams() fails to update extension parameters.
- getParam() always returns null.
- Installer scripts cannot manipulate extension parameters.
Expected result AFTER applying this Pull Request
- setParams() correctly updates extension parameters in #__extensions.
- getParam() correctly retrieves the parameter values.
- Installer scripts work as intended.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.3-dev
|
||
what @joomdonation said, this will break potentially things for people depending on id in their $this->paramTable
I have tested this item ✅ successfully on 01405ca
Thanks for this, appreciate it!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46195.
I have tested this item ✅ successfully on 01405ca
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46195.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46195.
@Aaqilyousuf We close an issue as soon as we have a PR for it.
This pull request has been automatically rebased to 5.4-dev.
| Labels |
Added:
RTC
bug
|
||
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
Removed: PR-5.3-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-16 11:50:07 |
| Closed_By | ⇒ | richard67 |
Thanks all (author and testers and reviewers).
Thanks for your work. However, this is not a complete fix. Please look at this block of code https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Installer/InstallerScript.php#L137-L141 ,
$this->paramTablecould be#__modulesor#__extensions, so you cannot always usesextension_idas the column name. It must be determined base on the value of$this->paramTable` (an if/else is needed here)