[#46173] - [5.4] Installation - Admin password must be at least 12 characters long
- Pending
- Medium
- Build: 5.3-dev
- # 46173
- Diff
- alikon:patch-32
User tests: Successful: Unsuccessful:
Pull Request for Issue #46111, #42289 .
Summary of Changes
Admin password must be at least 12 characters long and not contains spaces
Testing Instructions
Install Joomla 5.3.x
At Login Data: set a short <12 char and or use spaces as 'Set the username for your Super User account. *'
Actual result BEFORE applying this Pull Request
The installation process goes on until it gets stuck in the 'Installation progress' phase. There is no possibility to cancel, stop or do something other than go back in the browser.
Expected result AFTER applying this Pull Request
you cannot proceed untill you set a minimum password of 12 chars and without spaces
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
| Labels |
Added:
PR-5.3-dev
|
||
@tecpromotion no more hard-coded strings
I have tested this item ✅ successfully on 65a2286
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46173.
Does it make sense to check for invalid characters here as well, or do we need a new PR for that?
I just entered four letters and the rest as spaces. The bar turns green and at the very end, an error message appears saying that the password must not contain any spaces, and nothing works anymore.
Screenshot in german but you see the problem.
| Labels |
Added:
bug
|
||
the only chars that is been checked on installation should be spaces, check added
It works in principle, but the string JFIELD_PASSWORD_SPACES_IN_PASSWORD is not entirely correct, as spaces within the password are not accepted either. However, it only refers to the beginning and end.
then the text of JFIELD_PASSWORD_SPACES_IN_PASSWORD="Password must not have spaces at the beginning or end." is wrong
as it is only used here
joomla-cms/libraries/src/Form/Rule/PasswordRule.php
Lines 95 to 115 in 1b14ada
it should be JFIELD_PASSWORD_SPACES_IN_PASSWORD="Password must not have spaces."
This pull request has been automatically rebased to 5.4-dev.
Is the change only for the characters?
Because it's not the only issue here... the logics of validation IMO should change into the screen where you actually input the password...
@richard67 prebuild packages for this PR aren't available.
| Title |
|
||||||
@richard67 prebuild packages for this PR aren't available.
Seems they were too old and so deleted. I have just triggered a new build, they should be available again in some 30 minutes.
| Labels |
Added:
PR-5.4-dev
Removed: PR-5.3-dev |
||
@alikon Please do not use hard-coded strings. This should be a variable so that appropriate translations can be made in all languages.