[#46156] - [5.4] code cleanup
- Pending
- Medium
- Build: 5.4-dev
- # 46156
- Diff
- janschoenherr:patch-32
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Just a bit of code cleanup.
Testing Instructions
Use custom offline message on the offline page.
Actual result BEFORE applying this Pull Request
no change
Expected result AFTER applying this Pull Request
no change
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Front End Templates (site) | ⇒ | Front End com_users Templates (site) |
What is the benefit here? Not saying the change is wrong, but is there a performance gain or so?
But trim checks multiple characters. Anyway, don't want to block this. But not sure if the override notification is worth the change.
No need to hurry anyway. It might go into 5.4.1 and 6.0.1 because we are short before preparing RC 1, and between RC 1 and stable we only want to fix regressions, if some.
@richard67 Thanks, found a couple of more places.