[#46147] - [5.4] Fix missing copyright in media assets + always run versioning on media asset build
- Closed
- 1 Mar 2026
- Medium
- Build: 5.3-dev
- # 46147
- Diff
- LadySolveig:5.3/build/versioning-oninstall
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Alternative to #46146
This PR is based on #46146 and adds running the versioning script on every build with npm install or npm ci
Testing Instructions
WIP
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
@brianteeman Not really something to do here. @LadySolveig wanted to keep it open as a reminder for later discussions.
| Title |
|
||||||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
NPM Resource Changed
PR-5.4-dev
|
||
| Labels |
Removed:
Conflicting Files
|
||
@LadySolveig Even if it's only a draft and a reminder, I've allowed myself to solve the merged conflicts due to your other merged PR #46146 with the alternative approach. This was necessary for later being able to rebase the PR to 6.1-dev. The changed files should be the same as before, only that the later change from your PR #46609 is also included now. If that is wrong, please revert that.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-03-01 20:43:10 |
| Closed_By | ⇒ | LadySolveig |
Thank you Richard, since I hope this one #46879 will be merged, I will close for now.
I should have done that earlier. I hope you didn't have too much work to do with this.
If there is still a need for it afterwards, we can revisit, but I did not get the impression that there was much interest.
This pull request has been automatically rebased to 5.4-dev.