[#46134] - [5.4] PHP8.5 deprecated code
- Pending
- Medium
- Build: 5.4-dev
- # 46134
- Diff
- dgrammatiko:patch-3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Typecast some variables to string to eliminate the deprecation warnings on PHP 8.5
Deprecated: Using null as an array offset is deprecated, use an empty string instead in /xxxx/www/libraries/src/Document/HtmlDocument.php on line 533
Testing Instructions
Open the login page and check the deprecations (PHP8.5 required and error reporting to max)
Actual result BEFORE applying this Pull Request
Deprecations logged in the output
Expected result AFTER applying this Pull Request
No deprecations
B/C: since I'm not changing the signature of the function (arguments should be declared as strings and array there, maybe in J6) this should have zero impact to 3d pt devs.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@richard67 ping
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.4-dev
|
||
@dgrammatiko System test are failing.
Probably we should add PHP 8.5 to the matrix in system tests as well if possible.
We will see if we can do something in the ATT team.
I have tested this item ✅ successfully on 5d07d05
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46134.
I am not sure if this change has side effects.
The $name is not only used as array key but also passed as a parameter in the $this->setBuffer call further below here: 1f3d4b0ff411d275d94c1538ef487ef75d4450d772ad2cf712b5796467917f6dR568 .
The code in that method seems to use null values for the particular options if they are not given in the arguments.
With the change here that would be an empty string.
I have no idea what side effects this might have.
@richard67 The setBuffer method also changes $name to empty string if null https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Document/HtmlDocument.php#L603, so the change here does not have any effect for setBuffer call
The $name variable is also used in $renderer->render calls, I also checked and don't see any side affect. I also made real test and did not see any error.
@joomdonation I see. After having had a deeper look, it seems ok to me.
I don’t really need to be pinged for every 5.4-dev PR.