what is wrong with having multiple clients with the same name? They might have different contacts, purchase types or any of the other options

what is wrong with having multiple clients with the same name? They might have different contacts, purchase types or any of the other options

Thanks for your feedback!
I understand that multiple clients can have the same name, depending on contacts, purchase types, or other details.
The goal of this change is to help prevent accidental duplicates in the banner component. The idea is to show a warning to the admin instead of completely blocking duplicates, so they are reminded to differentiate the name—by adding a number or keyword. So admin can differentiate the name afterward without checking other details.

I’m happy to adjust this approach based on what the maintainers think.

Expected result AFTER applying this Pull Request
Duplicate client names are prevented and an error message is shown.

it does not do that

Expected result AFTER applying this Pull Request
Duplicate client names are prevented and an error message is shown.

it does not do that

Thanks for reviewing!
The warning is intentional — the idea is to alert the admin when a duplicate name is being saved, without completely blocking it.
So that admins can add number or keyword to differentiate the client names. So that afterward when admin will search for client he will able to differentiate the client without knowing other details.
It mainly helps prevent accidental duplicates.
This approach is non-destructive and preserves existing workflows.

I wanted to check if you think this approach is okay, or if you have suggestions to improve it further bcz i am a begineer.

The warning is intentional — the idea is to alert the admin when a duplicate name is being saved, without completely blocking it.

Just that it is not a warning (yellow) but an information (blue, "i" icon).

Personal opinion but you are fixing a problem that doesn't exist

Personal opinion but you are fixing a problem that doesn't exist

honestly it was my first open souce contribution. So im just trying to learn things. Maybe u can guide me for my future path.

Maybe u can guide me for my future path.

@WndSick Sorry, but maintainers and release managers like me do not have the time to guide every new contributor.

Besides that I agree with @brianteeman : This PR does not really fix a problem, it is superfluous. But maybe other opinions drop in.

Welcome @WndSick and thank you for your first try to contribute 🎉

It's wonderful that you are interested in the values and work for and behind open source and want to get involved. 💚

Perhaps it makes the most sense for you to first look at the open issues to see if you can resolve anything here.
Feel free to put your proposed solution up for discussion in the issue before you invest any work, as long as you are not yet completely confident.

It probably makes sense to read up a little here as well. https://manual.joomla.org/

The Bug Squad team is always happy to welcome new members and any helping hands. @MacJoom
https://volunteers.joomla.org/teams/bug-squad

As far as your PR is concerned, I agree with the other two. For this reason, I will close it at this point.

But I am delighted to welcome you as a volunteer with us and I hope I have been able to give you some useful pointers for your future path. 🚀