[#46038] - [6.0] Modularize Cassiopeia to make it easier for Child templates
- Pending
- Medium
- Build: 6.0-dev
- # 46038
- Diff
- dgrammatiko:6.0-dev/tmpls
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Modularize the cassiopeia (using Layouts) so changes on a child template could have a really small impact
Testing Instructions
Check that all 3 entries (index, error, offline, and component) are rendering exactly the same as before
Actual result BEFORE applying this Pull Request
Way too much code to sync between parent and child template
Expected result AFTER applying this Pull Request
No visual changes!
index
offline
error with debug
error no debug
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
PR-6.0-dev
|
||
If they have made a change in their index.php then they already have issues because we have updated that file multiple times
If they have made a change in their index.php then they already have issues because we have updated that file multiple times
@brianteeman Well, I do that on my home page. The override checker shows me if something has changed. I've never had any issues.
thats what i meant
But what does it mean for users who are using template overrides
they could keep the old override or create a specific layout override with their change. Both will work…
FWIW this modular approach makes it way easier to keep track of changes and also is less code for the maintainers…
No problems found with my own child templates with own index.php.
Needs some documentation but seems to be a good solution.
The more I think of it the more I think this (good idea) is something that should be done with a new site template and not with Cassiopeia. every site using Cassiopeia (even without modification) will get a notice in the admin after update that they have to check their template. Creating "worry/extra work" for everyone on update.
Looks good and a test on a fresh installation is flawless.
But what does it mean for users who are using template overrides and have made changes in the index.php?
Is it compatible with th PR #46034?