User tests: Successful: Unsuccessful:
Heading level selection for Article titles in mod_articles previously just went h1-h5. This adds h6 as an option.
Display Options tab and select h6 as your value for Header Level.No h6 was available in the list of options
h6 is now an available option.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Modules Front End |
I know, but we could use the form field everywhere - it simply generates the options for headings.
https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Form/Field/HeadertagField.php
I have tested this item ✅ successfully on c327cdd
Makes sense
@chmst I don't see how that's helpful in this use case. If we let you select h5 what's wrong with being able to select h6
Our global administrator language file has language strings JH1 to JH6: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/language/en-GB/joomla.ini#L35-L40
I see no reason why not to use all 6.
Only question is why not do the other modules, too?
The latter is legacy so maybe that should not be changed.
But the former still seems to be state of the art (not legacy) so that could be changed, too.
@brianteeman What do you think? Change these 2, too? Or only the former?
For consistency you are correct they should be changed. I leave it to the maintainers to decide if the legacy module should be updated or not.
I have tested this item ✅ successfully on c327cdd
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.4-dev
|
||
RTC
Final test before merge with JBT graft nightly build and full package from PR
✅ Seen h1 - h5 before, seen h6 after, checked HTML source code
Notes:
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-09 07:01:58 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
RTC
|
||
Thank you @travisrisner for your contribution. Thank you @brianteeman, @richard67 and @chmst for your comments. Thank you @brianteeman and @mothershedc for testing.
Or use the form field type="headertag" instead of all the Options?