RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar travisrisner
travisrisner
5 Sep 2025

Summary of Changes

Heading level selection for Article titles in mod_articles previously just went h1-h5. This adds h6 as an option.

Testing Instructions

  • Create a module using mod_articles
  • Select parameters that will list the modules
  • Go to the Display Options tab and select h6 as your value for Header Level.
  • View module on the frontend and ensure the article title is using the h6 tag

Actual result BEFORE applying this Pull Request

No h6 was available in the list of options

Expected result AFTER applying this Pull Request

h6 is now an available option.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar travisrisner travisrisner - open - 5 Sep 2025
avatar travisrisner travisrisner - change - 5 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2025
Category Modules Front End
avatar chmst
chmst - comment - 6 Sep 2025

Or use the form field type="headertag" instead of all the Options?

avatar brianteeman
brianteeman - comment - 6 Sep 2025

@chmst headertag is for the module title. This pr is for the article title

avatar chmst
chmst - comment - 6 Sep 2025

I know, but we could use the form field everywhere - it simply generates the options for headings.
https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Form/Field/HeadertagField.php

avatar brianteeman brianteeman - test_item - 6 Sep 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Sep 2025

I have tested this item ✅ successfully on c327cdd

Makes sense


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46037.

avatar brianteeman
brianteeman - comment - 6 Sep 2025

@chmst I don't see how that's helpful in this use case. If we let you select h5 what's wrong with being able to select h6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46037.

avatar richard67
richard67 - comment - 7 Sep 2025

Our global administrator language file has language strings JH1 to JH6: https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/language/en-GB/joomla.ini#L35-L40

I see no reason why not to use all 6.

Only question is why not do the other modules, too?

The latter is legacy so maybe that should not be changed.

But the former still seems to be state of the art (not legacy) so that could be changed, too.

@brianteeman What do you think? Change these 2, too? Or only the former?

avatar brianteeman
brianteeman - comment - 7 Sep 2025

For consistency you are correct they should be changed. I leave it to the maintainers to decide if the legacy module should be updated or not.

avatar mothershedc mothershedc - test_item - 8 Sep 2025 - Tested successfully
avatar mothershedc
mothershedc - comment - 8 Sep 2025

I have tested this item ✅ successfully on c327cdd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46037.

avatar richard67 richard67 - change - 8 Sep 2025
Status Pending Ready to Commit
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 8 Sep 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46037.

avatar muhme
muhme - comment - 9 Sep 2025

Final test before merge with JBT graft nightly build and full package from PR
✅ Seen h1 - h5 before, seen h6 after, checked HTML source code

Notes:

  • The 'Display Options > Header Level' is used for the article links, not for the module header (which is 'Advanced > Header Tag')
  • In 'Advanced > Header Tag' you already can choose h6.
  • In 'Advanced > Header Tag' you can also choose 'p' and 'div'.
    • For individual styling in 'Display Options > Header Level' you can choose the div's with class name.
  • But could uniform usage of header selection still be useful?
avatar muhme muhme - change - 9 Sep 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-09-09 07:01:58
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 9 Sep 2025
avatar muhme muhme - merge - 9 Sep 2025
avatar muhme
muhme - comment - 9 Sep 2025

Thank you @travisrisner for your contribution. Thank you @brianteeman, @richard67 and @chmst for your comments. Thank you @brianteeman and @mothershedc for testing.

Add a Comment

Login with GitHub to post a comment