@Dileepadari First of all thanks a lot for this PR. I've seen your presentation in JUG London recently and was very impressed.

Please forgive us if we already leave review comments and suggestions while this PR is still in draft status, i.e. not ready for review.

But I thought I should give early feedback on the basic things so you can fix them early before the more fine grained reviews drop in.

Please check the css you are adding. Some of it seems to be duplicating css already present in the admin template

Thanks a lot for all the feedback, I'm adding the language strings now and also will review the whole code once to remove redundancy. Thanks for the early feedback.

Thank you @Dileepadari for your contribution, that's a really nice feature!

@Dileepadari Not sure if it is a good idea to mark my change suggestions for the update SQL scripts as resolved without having implemented them.

Oh sorry, I am making changes in my local repo and marking as resolved whatever I have updated. So that I can get track of what else changes I need to do. Any other suggestions for that?

Oh sorry, I am making changes in my local repo and marking as resolved whatever I have updated. So that I can get track of what else changes I need to do. Any other suggestions for that?

@Dileepadari Whatever works best for you. But for readers it could be misleading if things are marked as resolved before the solution is visible here. 2 possible ways out: 1. You always push changes when done, and then mark as resolved here, or 2. keep a local list where you can mark what you have done locally.

ok @richard67, Thanks for the suggestion. second option looks good, ill make a list.

What are these supposed to do? I was never able to focus on them and if I unhide them the links all load the same page

Something weird going on when you try to open an action button with a click. It appears to work ok if the stage is not already active. But when it is active then the button does nothing

I can see that you have tried to make this accessible and supporting screen readers and I applaud you for trying. But have you actually tested it with a screen reader as I don't think it's working as you expect. I'm not even sure if it is even realistically achievable to support screen readers in this visual presentation

In the front end view some of the keyboard shortcuts still work but they are not documented. Also you dont get the mini map at the bottom left that you do in the admin

I think there is a z-index issue on the front end as some of the lines are on top of the boxes

Admin

Site

What are these supposed to do? I was never able to focus on them and if I unhide them the links all load the same page

Yeah I realized as it is single page, they are not necessary, removed them.

Something weird going on when you try to open an action button with a click. It appears to work ok if the stage is not already active. But when it is active then the button does nothing
chrome_s6qYY56Wla.mp4

Thanks for pointing out, I found a small bug, will fix it soon.

get the

We thought that the view only panel should be as minimal as possible as it has no other use case other than just viewing the connections and the flow, so we felt the mini-map is redundant, do we really need it?

get the

We thought that the view only panel should be as minimal as possible as it has no other use case other than just viewing the connections and the flow, so we felt the mini-map is redundant, do we really need it?

whatever the justification is for having it in the main admin view has not changed in the site view or article view.

Sorry I am going to back out of any further tests for this.

When I look at the Basic Workflow I dont see anything useful. For example it says there are 7 transitions but not what they are.

are they all on top of each other?

update to the last comment. Yes all the transitions are absolutely positioned in the same place. I was expecting something like this (with the correct lines as well)

Please revert the last commit updating tinymce

Thanks for fixing the transitions all being placed on top of each other

The hidden screenreader text uses "published/unpublished" but the visible text uses "enabled/disabled"

Update

Updated an existing test site (maybe unrelated issues so maybe someone else should test updating too):

activated workflows in com_content and clicked on the default workflow on graph:

clicked on stages:

Fresh install

Click on graph with the default com_content workflow:

• initial position is not optimal, maybe centered would be good if possible?
• Also irritating for me is that it goes from right to left per default

• wording of back is a bit irritating, should be close?

(sadly) Shortcuts work differently in joomla, with the j-prefix

I tested the following

• Create Stage
• Create transition
• Delete transition
• Change transition to new Stage
• Moved things around

I expect it's not planned to save the layout I rearranged? Or at least the screen position.

The points on the Stages are a bit strange. at least the color "white" seems not the best choice for the connection line on drag and drop.

I'm not sure what "Undo" and "Redo" does, it seems it's only for layout positions and only one step?
I would expect it could also change transitions and stage changes. It this is not the case I would remove the buttons.

I didn't looked at the code yet, but for this someone with more javascript knowledge should have a look maybe @laoneo ?