[#46025] - [5.4] autoupdate notification - remove redundant code, fix value 0
- Closed
- 9 Sep 2025
- Medium
- Build: 5.4-dev
- # 46025
- Diff
- chmst:54-autoupdate-simplify-code
User tests: Successful: Unsuccessful:
Follow up for #45721
.
Summary of Changes
Remove redundant code. The methods return arrays, check for is_array is redundant for super users groups.
Fix the following case:
Suppose we have for example name@domain.de, name2@domain.fr in the input field.
With ArrayHelper, this is transformed to an array, containing two elements with value 0.
The value 0 cannot be used as filter.group_id in the articles model.
Testing Instructions
see #45721
and set manually
$emailGroups = 'name@domain.de, name2@domain.fr';
in the sendNotification method in file administrator/components/com_joomlaupdate/src/Model/NotificationModel.php just after the $emailGroups = statement (line 61 without this PR, line 57 with this PR).
Actual result BEFORE applying this Pull Request
All users with sendEmail get the mail.
Expected result AFTER applying this Pull Request
Only superUsers get the mail
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Yes, methods return an array. It can be empty, but it is an array.
| Labels |
Added:
PR-5.4-dev
|
||
| Title |
|
||||||
| Labels |
Added:
bug
|
||
Setting this to draft as we must make sure that the filter.group_id is not 0.
Re-added code and fixed the following case.
Suppose a 3rd party extension has for example 'name@domain.de, name2@domain.fr' in the input field.
With ArrayHelper, this is transformed to an array, containing two elements with value 0.
The value 0 cannot be used as filter.group_id in the articles model.
Changed test instructions
| Title |
|
||||||
I have tested this item ✅ successfully on 1fb99eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46025.
I take a quick look at the current code which handles sending autoupdate notification. It does not looks good and it is also not optimized. If you agree, I will open a new PR to improve the current code (which BTW will replace this PR)
If you agree, I will open a new PR to improve the current code (which BTW will replace this PR)
@joomdonation Who shall agree?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-09 11:42:17 |
| Closed_By | ⇒ | chmst |
@joomdonation feel free
@joomdonation feel free
OK. Thanks. I will prepare a PR with necessary changes after PR #46050 merged to avoid conflict.
Is this also the case, when you select only one?