RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Aug 2025

Pull Request for Issue #33841 .

Summary of Changes

Move the message inside the fieldset so we dont have the ugly empty fieldset

Testing Instructions

This is a js change so either use a prebuilt package or apply the pr and run npm build:js

Install an additional language and enable the language filter plugin
Go to any article/menu etc and make sure the language is set to ALL
Go to the associations tab and check the results

Change the language of the item to anything other than ALL and verify that the associations fields are now displayed and the message is not

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 29 Aug 2025
avatar brianteeman brianteeman - change - 29 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2025
Category JavaScript Repository NPM Change
avatar exlemor exlemor - test_item - 29 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 29 Aug 2025

I have tested this item ✅ successfully on 362f8af

I have tested this successfully! Nice and easy one! Thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

avatar richard67 richard67 - test_item - 29 Aug 2025 - Tested successfully
avatar richard67
richard67 - comment - 29 Aug 2025

I have tested this item ✅ successfully on 362f8af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

avatar richard67 richard67 - change - 29 Aug 2025
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 29 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46011.

avatar richard67 richard67 - change - 29 Aug 2025
Labels Added: RTC
avatar muhme muhme - change - 29 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-29 17:37:01
Closed_By muhme
avatar muhme muhme - close - 29 Aug 2025
avatar muhme muhme - merge - 29 Aug 2025
avatar muhme
muhme - comment - 29 Aug 2025

✅ Final check before merge with JBT graft, installed German as extension, reproduced the problem and checked the fix

avatar muhme
muhme - comment - 29 Aug 2025

Thank you @brianteeman for your contribution. Thank you @exlemor and @richard67 for testing.

Add a Comment

Login with GitHub to post a comment