Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
26 Aug 2025

Pull Request for no issue

Summary of Changes

It is best practice that all content is contained by a landmark. On the login page of administrator the sidebar is not contained by a landmark. This PR will fix this

Testing Instructions

  • Go to Joomla Administrator
  • Open Dev Tools
  • notice that element with className sidebar-wrapper is not contained by a landmark.
  • Apply the PR
  • Refresh login page
  • Open Dev Tools
  • notice that element with className sidebar-wrapper is contained in landmark <aside>

Landmark <aside> is chosen because sidebar is supplementary support info

Actual result BEFORE applying this Pull Request

        <div id="sidebar-wrapper" class="sidebar-wrapper">

Expected result AFTER applying this Pull Request

        <aside id="sidebar-wrapper" class="sidebar-wrapper" aria-labelledby="main-brand">

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 26 Aug 2025
avatar hans2103 hans2103 - change - 26 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2025
Category Administration Templates (admin)
avatar brianteeman
brianteeman - comment - 26 Aug 2025

I agree with adding the landmark. Not sure about the arialabel. Will check in more detail later but I don't think it's needed or particularly helpful

avatar chmst
chmst - comment - 26 Aug 2025

I would like to have a landmark here and get rid of this ugly "missing landmark" error.
But am not sure if <aside is correct.
Semantic meaning is "content which is relaed to the main content and supports it".
We can define modules - there we know when the module is related to the main content.
But sidebar could be everything.
Would be interesting to know if the <aside helps blind users and has a meaning

avatar brianteeman
brianteeman - comment - 26 Aug 2025

Aside means it is complimentary to the main region but I wonder if it can be considered as complimentary as it has the page h1 in it.

avatar brianteeman
brianteeman - comment - 26 Aug 2025

The <aside> HTML element represents a portion of a document whose content is only indirectly related to the document's main content. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/aside

This suggests it's not the correct landmark region to use here

avatar chmst
chmst - comment - 26 Aug 2025

A <div role="complementary" could match.

avatar brianteeman
brianteeman - comment - 26 Aug 2025

A <div role="complementary" could match.

that is the exact same thing as aside https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/complementary.html

avatar brianteeman
brianteeman - comment - 26 Aug 2025

Not sure about the arialabel. Will check in more detail later but I don't think it's needed or particularly helpful

I was surprised that the label would identify the text as the referred id is to the div and not the individual text. So that arial label is both the h1 and the h2

In general a region only needs a label if there are more than one on the page but i dont suppose it harms having one anyway.

I wonder if this is the real main region on the page and its the login that is either complimentary or region https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/region.html

Add a Comment

Login with GitHub to post a comment