Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45851] - [5.4] Convert site mod_menu to service provider

RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
5 Aug 2025

Summary of Changes

Converts the site menu module to service provider.

Testing Instructions

  1. Make sure you have site module mod_menu published and configured
  2. You should see module output
mod_menu_site

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 5 Aug 2025
avatar joomlaweby joomlaweby - change - 5 Aug 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2025
Category ⇒ Modules Front End
avatar exlemor exlemor - test_item - 6 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 6 Aug 2025

I have tested this item ✅ successfully on 2a88403

I have successfully tested this. Thanks @joomlaweby!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

avatar travisrisner travisrisner - test_item - 7 Aug 2025 - Tested successfully
avatar travisrisner
travisrisner - comment - 7 Aug 2025

I have tested this item ✅ successfully on 2a88403

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

avatar richard67 richard67 - change - 7 Aug 2025
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 7 Aug 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45851.

avatar muhme muhme - change - 7 Aug 2025
Labels Added: RTC PR-5.4-dev
avatar muhme
muhme - comment - 7 Aug 2025

Final test before merge, with JBT graft full package

  • 'Log Almost Everything' enabled
  • Created a menu with some menu entries and one sub-menu entry
  • Created menu module with new menu and placed on sidebar-right -> working on frontend site
  • Tested module options (hide title, hide sub-menu, dropdown layout) -> working
  • Seen with logged in and logout user
  • No entries in administrator/logs/*
avatar muhme muhme - change - 7 Aug 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-08-07 17:30:30
Closed_By ⇒ muhme
avatar muhme muhme - close - 7 Aug 2025
avatar muhme muhme - merge - 7 Aug 2025
avatar muhme
muhme - comment - 7 Aug 2025

Thank you @joomlaweby for your contribution. Thank you @exlemor and @travisrisner for testing.

Add a Comment

Login with GitHub to post a comment