User tests: Successful: Unsuccessful:
Converts the administrator dashboard menu module to service provider.
Module works as expected
Module works same way as before applying pull request
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
Labels |
Added:
PR-5.4-dev
|
@joomlaweby So it seems when this PR will be merged, then there will be only one module left in 5.0-dev which has not been converted to service provider, that's module "administrator/mod_popular", which has been converted in 6.0-dev with PR #45808 .
All other admin and site modules are done.
Would be cool of course to have them all done in 5.4.0-beta1 (and of course also in 6.0.0-beta1), but that would mean to make a PR for 5.4-dev for "administrator/mod_popular" which contains some but not all of the changes from PR #45808 (I would then later help with the upmerge and solve conflicts so that in 6.0-dev the changes from PR #45808 are not lost .
@muhme @rdeutz What do you think? Should we do that last module in 5.4-dev?
If so, we should be fast as we want to build the beta1 packages end of next week.
I have tested this item ✅ successfully on ffd9028
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
✅ Final test before merge, with JBT graft from full update package
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-09 11:30:49 |
Closed_By | ⇒ | muhme |
Thank you @joomlaweby for your contribution. Thank you @brianteeman for your change proposal. Thank you @exlemor and @travisrisner for testing.
I have tested this item ✅ successfully on abf181c
I have successfully tested this. Thanks @joomlaweby!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45852.