User tests: Successful: Unsuccessful:
Pull Request for #45512 .
See description of PR #45512 :
@richard67 you might need to create an exception for these files in your deleted files script as they should be available on sites updated to j6 (unless we remove the tours completely in an sql update)
This pull request (PR) adds 2 folders to the list of folders not to be checked in the build/deleted_file_check.php
script which is used to check if there are deleted files or folders to be added to the administrator/components/com_admin/script.php
file.
The added folders belong to the Guided Tours for Joomla 5, which were removed with PR #45512 but shall not be removed when updating.
In addition, this PR fixes alpha-ordering of the mentioned list of folders not to be checked.
Finally, it adds the language files for the J5 Guided Tours to the list of files to be kept on update.
See also my PR #44912 for the same kind of thing in past.
The tests require PHP CLI so you can run PHP scripts on a command line, and it requires to be run on Linux or on Windows with WSL or on Mac OS. On Windows without WSL it does not work right. I will provide a fix for that sooner or later with another PR.
It is a stand-alone script and sop can be used even without the CMS.
tmp
folder of your Git clone and the package file names as folder names:php ./build/deleted_file_check.php --from=./tmp/Joomla_5.4.0-alpha4-dev-Development-Full_Package --to=./tmp/Joomla_6.0.0-alpha4-dev-Development-Full_Package
./build/deleted_files.txt
and ./build/deleted_folders.txt
.mv ./build/deleted_files.txt ./tmp/deleted_files_without-pr.txt
mv ./build/deleted_folders.txt ./tmp/deleted_folders_without-pr.txt
File ./build/deleted_files.txt
includes the following files:
'/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini',
'/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2_steps.ini',
'/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3.ini',
'/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_3_steps.ini',
'/media/com_guidedtours/images/5_2/enhancedtourheader.png',
'/media/com_guidedtours/images/5_2/mailtemplate.png',
'/media/com_guidedtours/images/5_3/filesdirectory.jpg',
'/media/com_guidedtours/images/5_4/automated-updates.jpg',
File ./build/deleted_folders.txt
includes the following folders:
'/media/com_guidedtours/images/5_4',
'/media/com_guidedtours/images/5_3',
'/media/com_guidedtours/images/5_2',
'/media/com_guidedtours/images',
Besides this, there might be other files and folders in these text files which are not relevant for this PR here.
Files ./build/deleted_files.txt
and ./build/deleted_folders.txt
do NOT include the files and folders mentioned in the previous section "Actual result BEFORE applying this Pull Request".
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Repository |
Labels |
Added:
PR-6.0-dev
|
Ping @Bodge-IT @softforge .