RTC NPM Resource Changed bug PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Aug 2025

Pull Request for Issue #45765 .

Summary of Changes

Force the choices background to be used even when mobile otherwise the selected choice is invisible

This is caused by a conflicting css rule that is triggered on mobile and gets priority

[aria-selected=true] {
background-color: var(--body-bg);
}

Someone with better css skills than me might have an alternative/better solution

Testing Instructions

Add a tag to an article and check that when on mobile (small screen) you can still see the selected tag

this is an scss change so you will either need to npm run build:css or use a prebuilt package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 5 Aug 2025
avatar brianteeman brianteeman - change - 5 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2025
Category Repository NPM Change
avatar exlemor exlemor - test_item - 6 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 6 Aug 2025

I have tested this item ✅ successfully on dd0875f

I have successfully test this. Nice catch @fuscage and nice fix @brianteeman.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842.

avatar alikon alikon - test_item - 6 Aug 2025 - Tested successfully
avatar alikon
alikon - comment - 6 Aug 2025

I have tested this item ✅ successfully on dd0875f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842.

avatar alikon alikon - change - 6 Aug 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 6 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842.

avatar rdeutz rdeutz - change - 7 Aug 2025
Labels Added: RTC NPM Resource Changed bug PR-5.3-dev
avatar richard67 richard67 - close - 7 Aug 2025
avatar richard67 richard67 - merge - 7 Aug 2025
avatar richard67 richard67 - change - 7 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-07 10:18:55
Closed_By richard67
avatar richard67
richard67 - comment - 7 Aug 2025

Thanks all (author and testers).

avatar brianteeman
brianteeman - comment - 7 Aug 2025

thanks

Add a Comment

Login with GitHub to post a comment