User tests: Successful: Unsuccessful:
Adds a "Year Filter Order" parameter to the archived articles menu item configuration, allowing users to sort years in ascending (oldest first) or descending (newest first) order.
Resolves #45772
filter_field_years
parameter to /components/com_content/tmpl/archive/default.xml
ArchiveModel::getYears()
to use the parameter with security validationStatus | New | ⇒ | Pending |
Category | ⇒ | Front End com_content Language & Strings |
Labels |
Added:
Language Change
PR-5.3-dev
|
Title |
|
I've rebased this PR for 5.4-dev for now. As said, 5.3 only receives bug fixes, no new features.
Labels |
Added:
PR-5.4-dev
Removed: PR-5.3-dev |
@Aashish-Jha-11 I used Patchtester to apply your PR to a copy of an existing site. I realized that the new option has not been included on the "Options", but on the "Archive" tab. IMHO this is the better place to put it. But you should change your testing instructions (and later the documentation) from "Archive Options tab" to "Archive tab".
Using Patchtester, I would not get the new language strings applied.
Apart from that, my test was okay. I will follow up a test with the Drone package to get the correct language strings.
I have tested this item 🔴 unsuccessfully on 9e8a206
The test is okay apart from the language strings:
you obviously have not tested your work as the language string MUST be added to the admin language file
@Aashish-Jha-11 your first contribution to Joomla! Welcome!
As Brian said, there are language files for the administrator and one for the CMS frontend. So please move yout Language Strings into the administrator /language/en-GB.
Move the language strings into:
/administrator/language/en-GB/com_content.ini
then it works.
@Aashish-Jha-11 your first contribution to Joomla! Welcome!
Labels |
Added:
Feature
|
Category | Front End com_content Language & Strings | ⇒ | Administration Language & Strings Front End com_content |
Hi @chmst! Thank you for the warm welcome and guidance! 🙌
You're absolutely right - I've now moved the language strings to /administrator/language/en-GB/com_content.ini
as requested. The implementation now follows Joomla's standard pattern for menu configuration language strings.
Thanks for the feedback!
@Sieger66 Exactly right! ✅
The language strings are now properly placed in /administrator/language/en-GB/com_content.ini
and removed from the site language file. This follows the correct Joomla pattern for menu configuration strings.
Thanks for confirming the correct location!
@brianteeman Thank you for the feedback! Sir
You're absolutely correct - the language strings are now properly added to the administrator language file at /administrator/language/en-GB/com_content.ini
. I've also removed the duplicate strings from the site language file as they should only exist in the admin context for menu configuration.
The implementation now follows proper Joomla standards. Thanks for the guidance!
@dautrich Thank you so much Sir for the detailed testing! 🙏
You're spot on about the field placement - it's in the "Archive" tab which is indeed the better location for this functionality. I've updated the testing instructions accordingly.
Regarding the language strings issue with Patchtester - this is a known limitation where Patchtester sometimes doesn't properly apply language file changes. The strings are correctly implemented in /administrator/language/en-GB/com_content.ini
and should work properly with the Drone package or a full installation.
Thanks for the thorough testing and helpful feedback!
Regarding the language strings issue with Patchtester - this is a known limitation where Patchtester sometimes doesn't properly apply language file changes. The strings are correctly implemented in /administrator/language/en-GB/com_content.ini and should work properly with the Drone package or a full installation.
No its not - you just put them in the wrong place
Please rename this to SORT not filter
Please move the field so that it is after the field "date for ordering" as its more logical to be placed there than after the filter field option
@brianteeman Thank you Sir for the specific feedback! ✅
I've implemented both of your requests:
Renamed from "FILTER" to "SORT": Changed language strings to COM_CONTENT_FIELD_YEAR_SORT_LABEL
and COM_CONTENT_FIELD_YEAR_SORT_DESC
, and updated the field name to year_sort_order
.
Repositioned the field: Moved it to appear right after the "Date for Ordering" field, which is indeed much more logical placement than after the filter field option.
The field now appears in this order:
Thanks for helping improve the UX! The implementation is now much more intuitive.
I have tested this item ✅ successfully on b490e06
I have tested this item ✅ successfully on b490e06
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Off-topic: You don't need to say "Thank you" so often here. I think that we all are here to help each other, and to help make Joomla an even greater product.
✅ Final test before merge
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-06 06:28:11 |
Closed_By | ⇒ | muhme |
Thank you @Aashish-Jha-11 for your contribution. Thank you @brianteeman, @Sieger66, @chmst and @QuyTon for supporting this PR. Thank you @dautrich and @ChristineWk for testing.
@muhme in your rush to merge this you ignored a perfectly valid CS change request from @QuyTon
@brianteeman The change request by @QuyTon was closed by @Aashish-Jha-11 before the merge, so @muhme could not see it and can't be blamed. Possibly a misunderstanding by @Aashish-Jha-11 .
Hi all,
Thanks @richard67 for highlighting this. I wasn’t aware that the change request from @QuyTon had been closed before the merge, which led to the oversight. It seems to have been a simple misunderstanding, and I’ll make sure to be more careful about review statuses in the future.
Sorry for the confusion caused.
Hi all,
Thanks @richard67 Sir for highlighting this. I wasn’t aware that the change request from @QuyTon had been closed before the merge, which led to the oversight. It seems to have been a simple misunderstanding, and I’ll make sure to be more careful about review statuses in the future.
Sorry for the confusion caused.
@Aashish-Jha-11 Hmm, you should remember from your previous PR that new features will not go into 5.3.