Thanks @Hackwar

You missed adding the new language strings

Thanks, should be fixed.

Pull Request for Issue #43110 and redo of #43909 .

Summary of Changes

This PR updates TinyMCE from version 6 to 8. The PR is based on the work of @brianteeman in #43909. Following is the description from his original PR:

The majority of changes with 7.x do not impact us as they are for the premium version and the premium plugins. Other changes are really just bug fixes and accessibility improvements.

The full changelog for the open source release of tinymce can be found here

Set tinymce to be used under the gpl licence. https://www.tiny.cloud/docs/tinymce/latest/license-key/#use-tinymce-with-the-gplv2-license - without this change a console warning is displayed

The one change that does need testing is sandbox_iframes

Testing Instructions

1. Test all editor-xtd buttons
2. Test the source code editor
3. Test any third party plugin eg https://github.com/brianteeman/slashtools
   This uses one of the few breaking changes so should fail https://www.tiny.cloud/docs/tinymce/latest/migration-from-6x/#the-autocompleter-ch-configuration-property-has-been-removed-use-the-trigger-property-instead I will make a new release of it but I am not aware of any other plugin using this.
4. Test drag and drop images

I can confirm the 1., 2., 4. work fine and 3. using Brian's slashtools does not as expected

5. Test content templates

I do not have (or so far couldn't find any content templates, would anyone have one that I can use to test against?)

@exlemor TinyMCE doesn't ship with pre-defined content templates. But you can create them yourself as text files, see e.g. description of PR #33130 . There is also a video in the description of that PR.

just logged in to post a link to one of my videos on this but I see now you already did

just logged in to post a link to one of my videos on this but I see now you already did

@brianteeman Now as you are logged in you could test the PR :-)

just logged in to post a link to one of my videos on this but I see now you already did

@brianteeman Now as you are logged in you could test the PR :-)

only on my phone - sorry. as the pr is based on my own code I didnt think I should be a tester anyway

I have tested this item ✅ successfully on 750ac46

I have successfully tested this! (Thanks @Hackwar!) and thank you @brianteeman @richard67 for the getting-me-to-the-right-video ;)

this is not updating the language files - we are still using very old tinymce language files from our translation teams

we should be using the latest official translations from tinymce - there are also more languages available than we have

You can see a list of available language files https://www.tiny.cloud/get-tiny/language-packages/

They can be installed using npm see https://github.com/mklkj/tinymce-i18n

Hups, indeed. I'll have a look later to fix this. The files currently are 4-6 years old.

its a legacy situation from when the TT lead insisted we had our own translations as he didnt like the ones from tiny

@brianteeman @dgrammatiko would it be okay this way?

Will check tomorrow

Code looks fine

looks like it is missing the step to minify the lang js files otherwise its all good

@richard67 will need your magic to remove the old files

For the minimization add the folder here:

I have not tested this item.

everything appears to work as expected including testing the language files and minification of the language files

however the minified language file is NOT being used. This might be beyond the scope of this PR as I spotted that joomla 5 is not using the minified language file either

however the minified language file is NOT being used. This might be beyond the scope of this PR as I spotted that joomla 5 is not using the minified language file either

I thought I have fixed that years ago

Found two issues with tinyMCE when testing this PR but they are not specific to this version of tinyMCE so shouldnt stop this PR being merged

See
#45877 Drag and Drop
#45876 Minified language files

They can be installed using npm see https://github.com/mklkj/tinymce-i18n

For reference:
#40418
joomla/core-translations#627

@heelc29 as nothing was done in over two years and its not some "random" npm package but one that has 25k downloads per week and has been actively maintained for three years this is the best approach imho

@Hackwar please check and update

sorry i checked the wrong branch - you did do it

@Hackwar sorry to mess you around. As it appears that tinymce has never been using the minified js language files can you revert that change and then we can merge this

@brianteeman which change do you mean? This PR pulls in the official translations and ships with both versions, the normal and the minified one. We can eventually fix the loading of the minified version, but ship with both right now.

I meant to remove the minification process. but if you want to keep it and fix their use later then thats cool as well. Its just that I realised that we have never been using the minified files even though they existed for years

@brianteeman The issue tracker still shows a valid, successful test from you. Is that right?

@exlemor Could you test again? Thanks in advance.

yes

I have tested this item ✅ successfully on e8519d6

applying the patch was harder then testing it. :-)

I was not able to press the button "apply patch" in the patch tester.
Therefor I have added @Hackwar as a remote server and checked out his branch 6.0-tinymce8

I will wait a bit with setting RTC so we can get more testers. The more, the better.

Although the instructions say that my slashtools plugin will not work because of a breaking change I did already update this last year and as long as you install it following the instructions in the readme of the plugin it works correctly in tinmyce8

Although the instructions say that my slashtools plugin will not work because of a breaking change I did already update this last year and as long as you install it following the instructions in the readme of the plugin it works correctly in tinmyce8

I did not encounter any issues with your slashdot plugin.
It seems that @Hackwar just copied your description from #43909

RTC

Thanks @Hackwar for the work on this and @brianteeman for the original work this PR is based on. thanks for testers @hans2103 and @exlemor