RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
31 Jul 2025

Summary of Changes

Converts the smart search module to service provider.

Testing Instructions

  1. Make sure you have site module mod_finder published
  2. You should see module output on frontend
mod_finder

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 31 Jul 2025
avatar joomlaweby joomlaweby - change - 31 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2025
Category Modules Front End
avatar exlemor exlemor - test_item - 31 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 31 Jul 2025

I have tested this item ✅ successfully on 638c10e

I have successfully tested this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45815.

avatar ghazal ghazal - test_item - 1 Aug 2025 - Tested successfully
avatar ghazal
ghazal - comment - 1 Aug 2025

I have tested this item ✅ successfully on 638c10e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45815.

avatar alikon alikon - change - 1 Aug 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45815.

avatar richard67 richard67 - change - 1 Aug 2025
Labels Added: RTC PR-5.4-dev
avatar rdeutz
rdeutz - comment - 1 Aug 2025

Really good work, looking forward to more!

avatar muhme
muhme - comment - 2 Aug 2025

Final test before merge with JBT graft Joomla_5.4.0-alpha4-dev+pr.45815-Development-Full_Package.zip

  • Installed Blog sample data (which includes 'Smart Search'), enabled 'Log Almost Everything'
  • ✅ Smart search is working, including autosuggest and highlighting what is already typed
  • ✅ Found the same number of articles (after some seconds): 12 x Joomla, 2 x typography, 1 x workflow and no articles found for 'Cheshire Cat'
  • ✅ No new JavaScript errors in console, no PHP errors, no Joomla log entries
avatar muhme muhme - change - 2 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-02 12:39:35
Closed_By muhme
avatar muhme muhme - close - 2 Aug 2025
avatar muhme muhme - merge - 2 Aug 2025
avatar muhme
muhme - comment - 2 Aug 2025

Thank you @joomlaweby for your contribution. Thank you @richard67 for your reviews. Thank you @exlemor and @ghazal for testing.

avatar joomlaweby
joomlaweby - comment - 3 Aug 2025

Really good work, looking forward to more!

Thanks!

Add a Comment

Login with GitHub to post a comment