RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
31 Jul 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adds new entries in the ignoreErrors section of the phpstan.neon file for deprecation errors of which we already know that they will be solved in J6 with the update of the database framework from 3 to 4, and removes the corresponding ignored errors from the phpstan-baseline.neon file, which are quite a lot.

These entries all were added to the phpstan-baseline.neon file with the update of the composer dependencies with my PR #45777 because the updated PHPstan version is more sensitive for such errors than the older version which we use in the 5.3-dev branch.

However, having them in the baseline file makes it hard to find them and remove them in 6.0-dev, and in 5.4-dev new PRs may require to add more entries in the baseline file.

So it is better to have general exclusions for these deprecations in the main configuration file phpstan.neon.

This is what this PR here does.

The new entries in the phpstan.neon file can be removed in 6.0-dev when that branch has gotten the framework update.

Testing Instructions

Code review and check CI:

  • Check that this PR only removes entries from the phpstan-baseline.neon file and does not add new one.
  • Check that PHPstan is successfull for this PR.

Actual result BEFORE applying this Pull Request

We have lots of exclusions in the phpstan-baseline.neon for calls to methods of deprecated interfaces Joomla\\Database\\Query\\PrepareableInterface and Joomla\\Database\\Query\\LimitableInterface.

Expected result AFTER applying this Pull Request

We no exclusions in the phpstan-baseline.neon for calls to methods of deprecated interfaces Joomla\\Database\\Query\\PrepareableInterface and Joomla\\Database\\Query\\LimitableInterface.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 31 Jul 2025
avatar richard67 richard67 - change - 31 Jul 2025
Status New Pending
avatar richard67 richard67 - change - 31 Jul 2025
Labels Added: PR-5.4-dev
avatar muhme muhme - change - 2 Aug 2025
Status Pending Ready to Commit
avatar muhme
muhme - comment - 2 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45814.

avatar muhme muhme - change - 2 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-02 08:46:13
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 2 Aug 2025
avatar muhme muhme - merge - 2 Aug 2025
avatar muhme
muhme - comment - 2 Aug 2025

Thank you @richard67 and @rdeutz.

Add a Comment

Login with GitHub to post a comment