I am trying to find a plugin that I could install that would let me see that this PR works (by it showing the changed text with the Patch applied and not show the text changed without the Patch) but am not having much luck, if you have one to offer that would make testing easier :)

@chmst or @peterhulst?

@exlemor you can use ContentNotifier (my plugin).
Put {jupdated} in the introtext of the article
Check that images are shown in the plugin parameters (set the truncation of the introtext to 0 instead 100, else this parameter is not visible. This is also a bug - i will make a report on this as well)

@exlemor I used the email cloak plugin which i triggered onContentPrepare.
Before patch - the email-adress is normal.
after patch: the email-address is converted by javascript.

They are not related. Sorry, wrong commit.

@exlemor I used the email cloak plugin which i triggered onContentPrepare. Before patch - the email-adress is normal. after patch: the email-address is converted by javascript.

I have tried it also the with email cloak plugin, but can not reproduce this behaviour.
Even if I disabled the Trigger Plugin Events (set to NO), the cloak plugin is still activated. I do not understand, where the onContentPrepare trigger for the cloak plugin comes from.
With my plugin ContentNotifier, the patch works correctly.

I used ContentNotifier to check.
Before patch - no display of a gif "updated" and {jupdated} is still visible.
After patch: the gif "updated" is displayed.

So the fix works correctly.

I used ContentNotifier to check. Before patch - no display of a gif "updated" and {jupdated} is still visible. After patch: the gif "updated" is displayed.

So the fix works correctly.

Thank you for the explanation and unfortunately for me I could not reproduce this because with your plugin I get the updated gif to appear both with or without patch (cleared cache and my test site is not CloudFlared) - I must be doing something wrong I am sure but not sure what.

maybe you can join the PR Testing group this afternoon and we can go through it together via video screen share ? :)

I used ContentNotifier to check. Before patch - no display of a gif "updated" and {jupdated} is still visible. After patch: the gif "updated" is displayed.
So the fix works correctly.

Thank you for the explanation and unfortunately for me I could not reproduce this because with your plugin I get the updated gif to appear both with or without patch (cleared cache and my test site is not CloudFlared) - I must be doing something wrong I am sure but not sure what.

maybe you can join the PR Testing group this afternoon and we can go through it together via video screen share ? :)

I have to say that I did the check on 5.4.0-alpha3 on a local installation (using Laragon), but the code is not changed on that point between 5.3.2 and 5.4.0-alpha3.
Strange that you can not reproduce and that it still works without the patch. Without the patch the onContentPrepare is not triggered. But in my case the email cloak plugin is also triggered without the patch, which I do not understand.

I am not available this afternoon; also I do not know how to join the PR Testing group.

I used ContentNotifier to check. Before patch - no display of a gif "updated" and {jupdated} is still visible. After patch: the gif "updated" is displayed.
So the fix works correctly.

Thank you for the explanation and unfortunately for me I could not reproduce this because with your plugin I get the updated gif to appear both with or without patch (cleared cache and my test site is not CloudFlared) - I must be doing something wrong I am sure but not sure what.
maybe you can join the PR Testing group this afternoon and we can go through it together via video screen share ? :)

I have to say that I did the check on 5.4.0-alpha3 on a local installation (using Laragon), but the code is not changed on that point between 5.3.2 and 5.4.0-alpha3. Strange that you can not reproduce and that it still works without the patch. Without the patch the onContentPrepare is not triggered. But in my case the email cloak plugin is also triggered without the patch, which I do not understand.

I am not available this afternoon; also I do not know how to join the PR Testing group.

Thank you and puzzling indeed..

Well, glad that you asked about the PR Testing Group, first recommendation:

Join the Joomla Community on Mattermost (you don't even have to download an app if you don't want to, you can simply use the web version) and there you can subscribe to the PR Testing Group channel - this initiative started by Philip (and Gary, I think) where we usually meet on Friday afternoon (even though sometimes I will do a session on Friday evening or the weekend to accommodate different time zones) is great to meet people from the community and test PR and learn from each other.

In the module Display Options tab the Trigger Plugin Events parameter has this Inline Help:

Enable this option to trigger three plugin events (afterDisplayTitle, beforeDisplayContent, afterDisplayContent) for each article in the results list.

It needs to be updated!

I too have struggled to find a practical example of where this patch makes a difference.

@ceford I have used my plugin "ContentNotifier" to discover the issue.

Add {jupdated} in the introtext of the article.
Check that Show Article Images: Show in the plugin parameters (set Introtext Limit (characters) to 0 instead 100, else this parameter is not visible. This is also a bug - i will make a report on this as well).

Before patch - no display of a gif "updated" and {jupdated} is still visible.
After patch: the gif "updated" is displayed.

@chmst please update MOD_ARTICLES_FIELD_TRIGGER_EVENTS_DESC