PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
18 Jul 2025

Summary of Changes

The Joomla CMS contains a http package which is almost an identical copy of the Joomla framework http package. This PR deprecates the CMS package and converts all CMS code to use the framework package with the PSR-7 interface.

Please note that there are small differences between the CMS and framework package, which I couldn't resolve directly. These would have to be reviewed and probably adapted for the framework package before 6.0 release:

  • HTTPFactory::getHttp() sets userAgent to Joomla <version>
  • Joomla\Http\Transport\Stream::getResponse() is not identical
  • Joomla\Http\Transport\Socket::getResponse() is not identical
  • Joomla\Http\Transport\Curl::getResponse() and redirectsAllowed() are not identical

The differences between the packages have adressed here: joomla-framework/http#67

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#498

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 18 Jul 2025
avatar Hackwar Hackwar - change - 18 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2025
Category Administration com_config com_installer com_joomlaupdate Libraries Front End Plugins
avatar Hackwar Hackwar - change - 19 Jul 2025
Labels Added: PR-6.0-dev
avatar Hackwar
Hackwar - comment - 3 Aug 2025

Large parts of this PR should be unnecessary when #45825 is merged.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2025
Category Administration com_config com_installer com_joomlaupdate Libraries Front End Plugins Libraries
avatar Bodge-IT
Bodge-IT - comment - 15 Aug 2025

Hi @Hackwar , got our eye this one Hannes. #45825 is merged, can we we close the loop on this one?

avatar Hackwar Hackwar - change - 15 Aug 2025
The description was changed
avatar Hackwar Hackwar - edited - 15 Aug 2025
avatar richard67 richard67 - test_item - 15 Aug 2025 - Tested successfully
avatar richard67
richard67 - comment - 15 Aug 2025

I have tested this item ✅ successfully on 0642199

Code review: All classes and methods have been deprecated (if they were not before), and the deprecation comments are correct.

The usage of the deprecated code has already been removed in the CMS (6-0-dev) with PR #45825 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45751.

avatar brianteeman
brianteeman - comment - 15 Aug 2025

How do you test the magic getter?

The rest is ok but as I can't test that part (yet) I can't give it a successful test

avatar LadySolveig LadySolveig - test_item - 15 Aug 2025 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 15 Aug 2025

I have tested this item ✅ successfully on 0642199

Code Review - LGTM


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45751.

avatar softforge softforge - change - 15 Aug 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-15 15:13:21
Closed_By softforge
avatar softforge softforge - close - 15 Aug 2025
avatar softforge softforge - merge - 15 Aug 2025
avatar softforge
softforge - comment - 15 Aug 2025

Thank you for your speedy fix and the testers for their amazing help

avatar richard67
richard67 - comment - 15 Aug 2025

How do you test the magic getter?

The rest is ok but as I can't test that part (yet) I can't give it a successful test

@brianteeman The getter is the same as in v3 of the framework package: https://github.com/joomla-framework/http/blob/3.x-dev/src/Response.php#L35-L61

avatar richard67
richard67 - comment - 15 Aug 2025

... except of the $stream->rewind();, which is new here, but that is necessary and just was missing the framework.

avatar brianteeman
brianteeman - comment - 15 Aug 2025

Thanks @richard67

I wonder how anyone was able to test it

Add a Comment

Login with GitHub to post a comment