User tests: Successful: Unsuccessful:
The Joomla CMS contains a http package which is almost an identical copy of the Joomla framework http package. This PR deprecates the CMS package and converts all CMS code to use the framework package with the PSR-7 interface.
Please note that there are small differences between the CMS and framework package, which I couldn't resolve directly. These would have to be reviewed and probably adapted for the framework package before 6.0 release:
HTTPFactory::getHttp()
sets userAgent
to Joomla <version>
Joomla\Http\Transport\Stream::getResponse()
is not identicalJoomla\Http\Transport\Socket::getResponse()
is not identicalJoomla\Http\Transport\Curl::getResponse()
and redirectsAllowed()
are not identicalThe differences between the packages have adressed here: joomla-framework/http#67
Codereview
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: joomla/Manual#498
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config com_installer com_joomlaupdate Libraries Front End Plugins |
Labels |
Added:
PR-6.0-dev
|
Category | Administration com_config com_installer com_joomlaupdate Libraries Front End Plugins | ⇒ | Libraries |
I have tested this item ✅ successfully on 0642199
Code review: All classes and methods have been deprecated (if they were not before), and the deprecation comments are correct.
The usage of the deprecated code has already been removed in the CMS (6-0-dev) with PR #45825 .
How do you test the magic getter?
The rest is ok but as I can't test that part (yet) I can't give it a successful test
I have tested this item ✅ successfully on 0642199
Code Review - LGTM
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-15 15:13:21 |
Closed_By | ⇒ | softforge |
Thank you for your speedy fix and the testers for their amazing help
How do you test the magic getter?
The rest is ok but as I can't test that part (yet) I can't give it a successful test
@brianteeman The getter is the same as in v3 of the framework package: https://github.com/joomla-framework/http/blob/3.x-dev/src/Response.php#L35-L61
... except of the $stream->rewind();
, which is new here, but that is necessary and just was missing the framework.
Thanks @richard67
I wonder how anyone was able to test it
Large parts of this PR should be unnecessary when #45825 is merged.