PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
18 Jul 2025

Summary of Changes

Add badge of CI workflow (GitHub Actions) to Readme file

Integration PR #45602

Testing Instructions

Check Readme file

Actual result BEFORE applying this Pull Request

No badge included

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 18 Jul 2025
avatar heelc29 heelc29 - change - 18 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2025
Category Repository
avatar richard67 richard67 - test_item - 23 Jul 2025 - Tested successfully
avatar richard67
richard67 - comment - 23 Jul 2025

I have tested this item ✅ successfully on 79654a6

Hint for other testers: Just check the changed files on GitHub for this PR. For the one changed file, use the "View file" option of the three dot menu at the top right corner of the changed file. Then you can see the new badge.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45753.

avatar richard67
richard67 - comment - 23 Jul 2025

@tecpromotion As you have reviewed the changes: Could you also submit a test in the issue tracker? Testing instructions see my test result comment.

avatar brianteeman
brianteeman - comment - 23 Jul 2025

I understand why Actions, Drone & Appveyor are present and under the title "Build Status"

I dont understand what the point is of displaying the version of php, node or npm is - especially as they have nothing to do with the build status. and if they do then why not say the versions of composer, mysql and postgres

avatar laoneo laoneo - change - 24 Jul 2025
Labels Added: PR-5.3-dev
avatar laoneo
laoneo - comment - 24 Jul 2025

Can you remove the drone and Appveyor as well? Because #45651 got merged.

avatar richard67
richard67 - comment - 24 Jul 2025

Can you remove the drone and Appveyor as well? Because #45651 got merged.

@laoneo But that PR did not remove appveyor completely. It is still running on the 5.3-dev branch, see https://ci.appveyor.com/project/release-joomla/joomla-cms/builds/52456442 .

avatar richard67
richard67 - comment - 24 Jul 2025

P.S.: Anyway, @laoneo is right, the Drone and Appveyor badges can be removed.

avatar laoneo
laoneo - comment - 24 Jul 2025

How did I miss it, the file should be removed as well.

avatar laoneo
laoneo - comment - 24 Jul 2025

See #45774

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2025
Category Repository Unit Tests Repository
avatar heelc29
heelc29 - comment - 24 Jul 2025

I updated PR to remove all appveyor related files, updated CODEOWNERS and excluded phpunit-windows.xml.dist from the package (similar #45730).

avatar brianteeman
brianteeman - comment - 24 Jul 2025

The title of this pr and therefore the commit message no longer represents the pr.

Add a Comment

Login with GitHub to post a comment