Feature RTC Language Change PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar travisrisner
travisrisner
10 Jul 2025

Pull Request for Issue #45689 .

Summary of Changes

  • Added support for a custom registration menu item link to the Users Login menu item (com_users).
  • Introduced a new customRegLinkMenu parameter in the menu item XML, mirroring the logic already present in the login module.
  • Login view (default_login.php) now outputs the registration link based on this custom menu parameter, fully supporting language and menu routing if set.
  • Falls back to the default registration view if no menu is selected.

Testing Instructions

  1. Go to Menus > [Your Menu] > Add/Edit Login Menu Item.
  2. You will see a new parameter to select a "Registration Page" at the bottom of the Options tab (below Logout section)
  3. Select any menu item you want to use for user registration, or leave it unset for default behavior.
  4. Visit the front-end login page using this menu item.
  5. Confirm that the registration link points to your selected custom menu if set, or the default registration view if not.

Actual result BEFORE applying this Pull Request

  • The registration link on the login page always points to the default registration view, with no way to override or select a custom menu item.
  • No option to select a custom registration menu item in the login menu item parameters.

Expected result AFTER applying this Pull Request

  • Site admins can select a custom menu item for the registration link in the login menu item parameters.
  • The login page registration link uses the selected menu item.
  • If no menu item is selected, the link defaults to the standard registration view (existing behavior).

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar travisrisner travisrisner - open - 10 Jul 2025
avatar travisrisner travisrisner - change - 10 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2025
Category Administration Language & Strings Front End com_users
avatar travisrisner travisrisner - change - 11 Jul 2025
Labels Added: Language Change PR-5.3-dev
avatar brianteeman brianteeman - test_item - 11 Jul 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Jul 2025

I have tested this item ✅ successfully on 99bb9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar RickR2H RickR2H - test_item - 14 Jul 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 14 Jul 2025

I have tested this item ✅ successfully on a52b51a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar RickR2H
RickR2H - comment - 14 Jul 2025

@brianteeman could you please test again? Only the indentations have been changed. Maybe a code review will be enough.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar mothershedc
mothershedc - comment - 15 Jul 2025

I have tested this item ✅ successfully on a52b51a

avatar RickR2H
RickR2H - comment - 15 Jul 2025

@travisrisner please check if you can fix the phpstan issues.

avatar brianteeman
brianteeman - comment - 15 Jul 2025

@RickR2H they are unrelated to this PR

avatar rosslace rosslace - test_item - 15 Jul 2025 - Tested successfully
avatar rosslace
rosslace - comment - 15 Jul 2025

I have tested this item ✅ successfully on a52b51a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar RickR2H RickR2H - change - 15 Jul 2025
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 15 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar travisrisner travisrisner - change - 16 Jul 2025
Labels Added: RTC
avatar rdeutz
rdeutz - comment - 31 Jul 2025

This is not a bug fix it is more a new feature. It is up to the 5.4 RM if they want to include it in 5.4 or if we are moving this directly to 6.0 @richard67 @muhme

avatar richard67 richard67 - change - 31 Jul 2025
Labels Added: Feature PR-5.4-dev
Removed: PR-5.3-dev
avatar rdeutz rdeutz - change - 1 Aug 2025
Title
[5.3] Add support for custom registration menu link in com_users login menu item
[5.4] Add support for custom registration menu link in com_users login menu item
avatar rdeutz rdeutz - edited - 1 Aug 2025
avatar richard67 richard67 - change - 2 Aug 2025
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 2 Aug 2025

Back to pending as the PR has received a code change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar richard67
richard67 - comment - 2 Aug 2025

@brianteeman @RickR2H @mothershedc @rosslace Whoever has time: Could you test again? The PR has received a code change so it needs to check if it still works. 2 tests are successful, so if you see that it has already received 2 new tests, all is done. Thanks in advance.

avatar muhme muhme - change - 3 Aug 2025
Labels Removed: RTC
avatar RickR2H RickR2H - test_item - 5 Aug 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 5 Aug 2025

I have tested this item ✅ successfully on c987b75


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar richard67 richard67 - alter_testresult - 11 Aug 2025 - RickR2H: Tested successfully
avatar exlemor exlemor - test_item - 11 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 11 Aug 2025

I have tested this item ✅ successfully on 15833e8

I have tested this successfully... @travisrisner

(Testing instructions needed Step 0 - User --> Options --> Allow User Registration = Yes ) ;)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar richard67 richard67 - change - 11 Aug 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45715.

avatar muhme
muhme - comment - 11 Aug 2025

✅ Final test before merge, JBT graft full package

  • Enabled 'Log Almost Everything' and 'Allow User Registration'
  • Tested default 'Create an account' from login form
  • Installed German language packate as extension and set as default, default is working
  • Test of the new 'Login Form' menu type option 'Registration Page', including clear, direct editing of the menu item itself, selection of another menu item, clear again to have default
  • No entries in administrator/logs/*
avatar muhme muhme - change - 11 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-11 19:23:52
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 11 Aug 2025
avatar muhme muhme - merge - 11 Aug 2025
avatar muhme
muhme - comment - 11 Aug 2025

Thank you @travisrisner for your contribution. Thank you @brianteeman, @HLeithner, @rdeutz and @QuyTon for supporting. Thank you @mothershedc, @rosslace, @RickR2H and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment