[#45713] - [5.4] Model\AfterCleanCacheEvent event class is not forced for onContentCleanCache events
- Fixed in Code Base
- 23 Aug 2025
- Medium
- Build: 5.3-dev
- # 45713
- Diff
- Denitz:patch-23
User tests: Successful: Unsuccessful:
Summary of Changes
BaseDatabaseModel uses Model\AfterCleanCacheEvent event class to dispatch default onContentCleanCache event.
But this event class is not registered for this event name.
Hence, old-style (legacy) dispatching like:
$options = array(
'defaultgroup' => 'com_plugins',
'cachebase' => $jconf->get('cache_path', JPATH_SITE . '/cache')
);
$app->triggerEvent('onContentCleanCache', $options);will use default Event class, while for consistency, we should have Model\AfterCleanCacheEvent class.
Testing Instructions
Register own listener for onContentCleanCache event using Model\AfterCleanCacheEvent param class:
public function onContentCleanCache(Model\AfterCleanCacheEvent $event)
Execute old-style event dispatch without event instance like above.
Actual result BEFORE applying this Pull Request
See invalid param type error, $event is instance of Event class.
Expected result AFTER applying this Pull Request
No errors, the $event is instance of Model\AfterCleanCacheEvent.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Please rebase to 5.4
| Title |
|
||||||
Done.
| Labels |
Added:
bug
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 8883ae8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45713.
I have tested this item ✅ successfully on 8883ae8
Tested by code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45713.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45713.
I don't think it needs real tests which require some coding as it is a no-brainer.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-23 05:43:20 |
| Closed_By | ⇒ | muhme |
Thank you @Denitz for your contribution. Thank you @Fedik and @richard67 for testing.
@Fedik Should I rebase it to 5.4, or 6.0?