User tests: Successful: Unsuccessful:
The default values for file extensions were out of sync. No idea why we have it in so many places but at least now they should all match
code review
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media SQL Installation Postgresql Libraries Front End Plugins |
Labels |
Added:
PR-5.3-dev
|
Could you explain what you mean by out of sync?
the lists do not match - they should
I have tested this item ✅ successfully on 3841bed
I have tested this item 🔴 unsuccessfully on cc1135a
Where .ico is allowed to be uploaded. It will fail in the validation as it is not marked as image nor is the mimetype added to the validation.
The following actions are needed for ico to be allowed.
mysql/base.sql:171
postgresql/base.sql:177
plugins/editors-xtd/image/src/Extension/Image.php:124
@ricardo1709 there is nothing in this PR that changes anything to do with ico files. Any issues regarding using ico files are beyond the scope of this pr
@brianteeman Yes, it is relevante to this pr as the values are not sync to the validation. This is the same issue as ".doc" had. Which was fixed in this pr.
Link to the commit below.
eb6d66f
Guess you will need to make your own pr. Not wasting my time with bikeshedding
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-11 09:10:42 |
Closed_By | ⇒ | brianteeman |
Could you explain what you mean by
out of sync
? I notice that some of the revised lists are not in alphabet order. Is that significant? The sql statements are difficult to read in the diff.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45716.