PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Jul 2025

The default values for file extensions were out of sync. No idea why we have it in so many places but at least now they should all match

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 11 Jul 2025
avatar brianteeman brianteeman - change - 11 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2025
Category Administration com_media SQL Installation Postgresql Libraries Front End Plugins
eb6d66f 22 Jul 2025 avatar brianteeman doc
avatar brianteeman brianteeman - change - 22 Jul 2025
Labels Added: PR-5.3-dev
avatar ceford
ceford - comment - 28 Jul 2025

Could you explain what you mean by out of sync? I notice that some of the revised lists are not in alphabet order. Is that significant? The sql statements are difficult to read in the diff.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45716.

avatar brianteeman
brianteeman - comment - 28 Jul 2025

Could you explain what you mean by out of sync?

the lists do not match - they should

avatar RickR2H RickR2H - test_item - 31 Jul 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 31 Jul 2025

I have tested this item ✅ successfully on 3841bed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45716.

avatar QuyTon QuyTon - alter_testresult - 9 Aug 2025 - RickR2H: Tested successfully
avatar ricardo1709 ricardo1709 - test_item - 11 Aug 2025 - Tested unsuccessfully
avatar ricardo1709
ricardo1709 - comment - 11 Aug 2025

I have tested this item 🔴 unsuccessfully on cc1135a

Where .ico is allowed to be uploaded. It will fail in the validation as it is not marked as image nor is the mimetype added to the validation.
The following actions are needed for ico to be allowed.

mysql/base.sql:171

  • image_extensions | Missing ico
  • upload_mime | Missing image/vnd.microsoft.icon

postgresql/base.sql:177

  • image_extensions | Missing ico extension
  • upload_mime | Missing image/vnd.microsoft.icon

plugins/editors-xtd/image/src/Extension/Image.php:124

  • Missing ico extension

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45716.
avatar brianteeman
brianteeman - comment - 11 Aug 2025

@ricardo1709 there is nothing in this PR that changes anything to do with ico files. Any issues regarding using ico files are beyond the scope of this pr

avatar ricardo1709
ricardo1709 - comment - 11 Aug 2025

@brianteeman Yes, it is relevante to this pr as the values are not sync to the validation. This is the same issue as ".doc" had. Which was fixed in this pr.

Link to the commit below.
eb6d66f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45716.
avatar brianteeman
brianteeman - comment - 11 Aug 2025

Guess you will need to make your own pr. Not wasting my time with bikeshedding

avatar brianteeman brianteeman - change - 11 Aug 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-08-11 09:10:42
Closed_By brianteeman
avatar brianteeman brianteeman - close - 11 Aug 2025

Add a Comment

Login with GitHub to post a comment