Joomla! Issue Tracker | Joomla! CMS #45700 - [5.x][6.x] Missing CurrentUser if model is created with MVCFactory

No Code Attached Yet

New
Medium
Build: 5.3-dev
# 45700

heelc29
7 Jul 2025

Steps to reproduce the issue

If a Model, View, Table with the MVCFactory not all (required) options are injected to the objects eg. CurrentUserInterface because its injected by BaseController and not by the factory itself.

joomla-cms/libraries/src/MVC/Controller/BaseController.php

Lines 580 to 582 in 8868adc

    
           if ($model instanceof CurrentUserInterface && $this->app->getIdentity()) { 
        
               $model->setCurrentUser($this->app->getIdentity()); 
        
           }

joomla-cms/libraries/src/MVC/Controller/BaseController.php

Lines 611 to 613 in 8868adc

    
           if ($view instanceof CurrentUserInterface && $this->app->getIdentity()) { 
        
               $view->setCurrentUser($this->app->getIdentity()); 
        
           }

if you disabled this deprecated code

joomla-cms/libraries/src/User/CurrentUserTrait.php

Lines 43 to 49 in 8868adc

    
           if (!$this->currentUser) { 
        
               @trigger_error( 
        
                   \sprintf('User must be set in %s. This will not be caught anymore in 6.0', __METHOD__), 
        
                   E_USER_DEPRECATED 
        
               ); 
        
               $this->currentUser = Factory::getApplication()->getIdentity() ?: Factory::getUser(); 
        
           }

Expected result

no additional injects necessary if model/view/table etc. is created with MVCFactory

Actual result

you get problems with this code

joomla-cms/modules/mod_articles/src/Helper/ArticlesHelper.php

Line 58 in 8868adc

    
           $articles = $factory->createModel('Articles', 'Site', ['ignore_request' => true]);

joomla-cms/modules/mod_articles/src/Helper/ArticlesHelper.php

Line 278 in 8868adc

$items = $articles->getItems();

ping @laoneo

heelc29 - open - 7 Jul 2025

joomla-cms-bot - change - 7 Jul 2025

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 7 Jul 2025

laoneo - comment - 7 Jul 2025

The MVCFactory per se is not created in a context where a user is available. So where should this user come from?

heelc29 - comment - 7 Jul 2025

The MVCFactory per se is not created in a context where a user is available. So where should this user come from?

I have no idea, that's why I asked for advice. This means that every time you boot a different model in a plugin/module etc. you would have to inject the user separately - this will be a few places and the 3rd party developers will not be happy about it either.

That's how I've always understood it so far: If the model/view/table is created via the MVCFactory, you are on the safe side.

HLeithner - comment - 7 Jul 2025

The MVC doens't know the current User context, only the calling code knows what's the current user is. It would be more intuitive to provide a container with everything the model might need in the current context but that's not the design here...

laoneo - comment - 7 Jul 2025

This is what dependency injection is about. You need a context where it is running in

HLeithner - comment - 8 Jul 2025

MVCFactory doesn't allow you to provide a container...

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#45700] - [5.x][6.x] Missing CurrentUser if model is created with MVCFactory

Steps to reproduce the issue

Expected result

Actual result

Add a Comment

	if ($model instanceof CurrentUserInterface && $this->app->getIdentity()) {
	$model->setCurrentUser($this->app->getIdentity());
	}

	if ($view instanceof CurrentUserInterface && $this->app->getIdentity()) {
	$view->setCurrentUser($this->app->getIdentity());
	}

	if (!$this->currentUser) {
	@trigger_error(
	\sprintf('User must be set in %s. This will not be caught anymore in 6.0', __METHOD__),
	E_USER_DEPRECATED
	);
	$this->currentUser = Factory::getApplication()->getIdentity() ?: Factory::getUser();
	}