I think the test instructions need some clarification. What I did seemed to work first time but I needed to check and what I did the second time did not work (the Autoupdates was still enabled). My procedure:

1. Installed latest Nightly Build full package for 5.4.0-alpha3-dev.
2. Installed Patchtester and applied patch.
3. Installed latest Nightly Build update package for 5.4.0-alpha3-dev.
4. Back to Home Dashboard to see status of Automated Updates.

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45697.}

@ceford thank you so much for taking the time to test the patch, it's very much appreciated!

You are right, the test instructions have been unclear! I've updated the description and provided some more meaningful instructions.

Tested with new instructions.

With patch 45696 the new installation seemed to be as expected. Auto-update was not enabled on installation.

With patch 45697 and Disable Automated Updates not selected the installation was normal. However:

With patch 45697 and Disable Automated Updates selected there was a snag: the Automated Updates box disappeared but the Install Additional Languages button and the Remove Installation Folder button were both greyed. The Open Administrator button worked but I can see that the installation folder is still present.

@ceford do make sure I got that correclty: the installation and languages button were disabled when you hit the "disabled auto updates" button?

@ceford do make sure I got that correclty: the installation and languages button were disabled when you hit the "disabled auto updates" button?

Yes, as shown in the screen shots. In the second one the Open Site and Open Administrator buttons look dim but I am fairly sure they were not disabled. I logged in as Admin OK. I just logged in to check and Automatic Updates are disabled.

I have updated the branch to get progress on this PR, to be included within beta1, but PHPStan fails with Instantiated class JConfig not found. Please assist.

I have tested this item ✅ successfully on 27dfd62

Beforehand: I could not reproduce the issue with the disabled 'Remove installation folder' button. I removed the installation folder each time.

Tested with manual installation from full package on local site

• 1st time disabled Automated Updates on remove view and checked Automated Updates are disabled
• 2nd time didn't disable Automated Updates on remove view and checked Automated Updates:
  • Home Dashboard call there is yellow 'Automated Updates unavailable.'
  • Click in 'Automated Update' shows Automated Update: No
  • I can enable Automated Update and Save & Close, afterwards error message
    • The automated update service is unavailable for your site as it's not accessible from the internet. Automated updates have been disabled.
    • and Automated Updates remains disabled

Tested with manual installation from full package on public site

• Didn't disable Automated Updates on remove view and checked Automated Updates:
  • ✅ Home Dashboard shows green 'Automated Updates are enabled.'
  • ✅ Click in 'Automated Update' shows Automated Update: Yes, update token and last checked date today

    ---

    _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45697.}

I have updated the branch to get progress on this PR, to be included within beta1, but PHPStan fails with Instantiated class JConfig not found. Please assist.

Fixed

@ceford could you please test again? To see Automated Updates enabled, it is important to test from a publicly available site. If you encounter the disabled button issue again, could you please provide more details, such as the browser used, as I had no problems deleting the installation folder using the given button. Perhaps the save way for installation is from the full package. Thank you.

I've updated the links to packages in the description of this PR so testers can be sure to have packages which are up to date with latest 5.4-dev.

I have tested this item 🔴 unsuccessfully on c79fb16

If I proceed with the buttons from top to bottom, i.e. first opt out from the auto updates and then delete the installation folder, it works fine.

But if I decide to first use the button to delete the installation folder and then the button to opt out from the automated updates, then the latter button does not have any effect, and in network analysis of browser developer tools I see a POST request to https://test3.richard-fath.de/installation/index.php?task=installation.disableAutomatedUpdates&format=json with a 404 result.

The button for installing additional languages is removed (or hidden) when the button for deleting the installation folder has been used and the installation folder has been deleted.

This is correct as that button will not work after the installation folder has been removed.

We need the same logic for removing (or hiding) the new button to opt out from the auto updates.

P.S.: I think that it is here where the buttons are disabled after deleting the installation folder: https://github.com/joomla/joomla-cms/pull/45697/files#diff-d9f8a6c89739f0469e6ad48530ab28a41675604c9aad1d871c83a5f3f8032285R109-R121

@richard67 good catch, fix has been pushed

@ceford The disabled button issue should be solved now with the latest changes.

@SniperSister Still not perfect. Now the button for opt out is deactivated, but in opposite to the additional languages installation thing not hidden. I will later look if I can find the reason.

I have tested this item ✅ successfully on e23dc6f

I've also tested this additional test case:

At the final page, directly use the button to remove the installation folder.

Result: Anything related to the languages installation, the new option added by this PR here and the button to remove the installation folder are removed from the page because all that stuff cannot be used after the installation folder has been removed, and only the buttons for going to administrator or site remain.

This is the existing behaviour without this PR. The PR does not change anything on it, it only makes sure the new option is also handled like this.

Maybe not good UX, but nothing to be fixed with this PR here.

@ceford Could you test this PR again? Just use the installation package created for this PR by drone. I've updated the link in the description. No need to apply any other PR in addition. The actual result without this PR you don't need to test again. The issue you had should be solved. Thanks in advance.

There is still something not quite right! I installed the installation package with the PR linked in the instructions and stepped through the process. This time, after using Disable Automatic Updates, when I selected Remove Installation Folder the response screen still had a 'We detected development mode' message and the red 'Remove "Installation" folder' greyed out and I can see the installation folder has not been deleted. I can go on to Site or Admin screens.

@ceford Is is a Windows server? If so, this is due to issue #37909 . That is the expected behaviour for that case. If everything else was working for you, I would call it a successful test. But if it is Linux then there might be a permission issue when deleting the installation folder. That would have the same result.

@ceford Is is a Windows server? If so, this is due to issue #37909 . That is the expected behaviour for that case. If everything else was working for you, I would call it a successful test. But if it is Linux then there might be a permission issue when deleting the installation folder. That would have the same result.

It is a Linux server. My own VPS with WHM and several cPanel accounts. The installation folder has 0775 permissions - exactly the same as all other folders.

@ceford I can confirm your finding and that the installation folder has not been deleted.

I have tested this item 🔴 unsuccessfully on e23dc6f

I can reprpduce @ceford 's finding. Procedure:

1. Made a new installation with the patched package of this PR.
2. At the final page clicked the button to disable the auto updates.
   Result: The buttons for installing additional languages and for deleting the installation folder are still visible but disabled.
   So you can't delete the installation folder anymore.

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45697.}

@richard67 took a closer look at the button problem and suggested a bunch of changes, thank you!

Please retry.

I have tested this item ✅ successfully on 04ca14d

Now it works as expected.

@ceford Sorry to bother you again. Fist of all thanks for your help and your patience. Now with the latest fix it id working for me as expected. I've updated the link to the package in the testing instructions so you will get the newest one with these changes. Could you test again? That would be great. Thanks in advance.

I have tested this item ✅ successfully on 04ca14d

My previous test used my installation in a subfolder (not inside another joomla installation) because I forgot my set up. This one uses the subdomain I previously set up. I t now works as expected.

@ceford Thanks a lot for your effort for testing.

RTC

✅ Final test before merge with multiple manual full package installation on public site (always disabling AU afterwards)

• English (en-GB) Not disabled AU, delete installation folder, opened administrator -> AU is enabled, token is there
• German (Germany) Disable AU, delete installation folder is working with removed installation and disabled AU
• English (en-US) Not disable AU, not delete installation folder, opened administrator -> AU is enabled, token is there, installation folder exists
• Spanish (es-ES) First delete installation folder, no button Disable AU any more, AU is enabled, token is there, installation folder is deleted

Thank you @SniperSister and @brianteeman for your contribution. Thank you @ceford and @richard67 for repeated testing.