[#45701] - [5.3] contenthistory entries are now deleted with tag and content category
- Closed
- 29 Aug 2025
- Medium
- Build: 5.3-dev
- # 45701
- Diff
- alikon:patch-30
User tests: Successful: Unsuccessful:
Pull Request for Issue #45584 .
Summary of Changes
added the delete method
Testing Instructions
Tags
- Create one tag
- Check database table __history and see item_id entry com_tags.tag.id
- Trash and delete the tag
- The database table __history entry for com_tags.tag.id is still existing
Content Categories
- Create one content category
- Check database table __history and see item_id entry com_content.category.id
- Trash and delete the category
- The database table __history entry for com_content.category.id is still existing
Actual result BEFORE applying this Pull Request
Related contenthistory entries are are still existing after deleting a tag or a content category.
Expected result AFTER applying this Pull Request
Related contenthistory entries are deleted together with the tag and the content category.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
| Labels |
Added:
PR-5.3-dev
|
||
| Category | Administration com_categories | ⇒ | Administration com_categories com_tags |
| Title |
|
||||||
I have tested this item ✅ successfully on b93c809
I have tested this successfully. Nice find/fix. Thanks @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45701.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45701.
I don't think it is a good way how this is implemented, I would prefer a more generic approach
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-29 08:21:47 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
bug
RMDQ
|
||
I am closing this PR, it is the wrong fix.
At some point in the past we changed the event from "onBeforeDelete" to "onTableBeforeDelete" but the nested table class wasn't change. So the "Behaviour\Versionable" Plugin don't get called when an item (nested as Tag and Category are) deleted and so the version stay.
The correct fix would be to change the called event but this needs a bit more investigating what are site effects could be.
Thanks for testing and spending time on this issue.
I have tested this item ✅ successfully on b93c809
Tested with JBT, first current behavier with 5.3-dev and checking the _history table:
Grafted Joomla_5.3.3-dev+pr.45701-Development-Full_Package.zip
Well done, thanks @alikon for fixing the issue!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45701.