RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
7 Jul 2025

Summary of Changes

remove deprecated access to AbstractView::get() for layout files

@Hackwar as negative side effect #44162 the access to protected properties of the view class is no longer possible. Is that acceptable?

if (isset($this->$property)) {
return $this->$property;
}

Testing Instructions

check views still working eg.

  • banner edit view (backend)
  • admin module edit view (backend)
  • categories view of contact, content, newsfeeds (frontend)
  • category view of contact, content, newsfeeds (frontend)

Actual result BEFORE applying this Pull Request

deprecated access to method get of AbstractView

Expected result AFTER applying this Pull Request

no deprecated access to method get of AbstractView

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 7 Jul 2025
avatar heelc29 heelc29 - change - 7 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2025
Category Administration com_menus Front End com_contact com_content com_newsfeeds Layout Libraries
avatar heelc29 heelc29 - change - 8 Jul 2025
Labels Added: PR-5.4-dev
avatar exlemor exlemor - test_item - 12 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 12 Jul 2025

I have tested this item ✅ successfully on 60d1379

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.

avatar heelc29 heelc29 - change - 24 Jul 2025
Title
[5.4] Remove deprecation AbstractView::get() in layouts
[5.4] Replace deprecation AbstractView::get() in layouts
avatar heelc29 heelc29 - edited - 24 Jul 2025
avatar hans2103 hans2103 - test_item - 25 Jul 2025 - Tested successfully
avatar hans2103
hans2103 - comment - 25 Jul 2025

I have tested this item ✅ successfully on 60d1379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.

avatar richard67 richard67 - change - 25 Jul 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 25 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.

avatar muhme muhme - change - 26 Jul 2025
Labels Added: RTC
avatar muhme
muhme - comment - 26 Jul 2025

Final test before merge, before applying this PR, with JBT graft Joomla_5.4.0-alpha4-dev-Development-Full_Package.zip, used links are listed – IDs needs to be picked-up from backend:

  • Renamed all uncategorised to Content-Uncategorised, Banners-Uncategorised and Contacts-Uncategorised
  • Created one article, one banner, one contact and one news feed entry
  • Banner edit view (backend)
    • Components > Banners > Banners > First Banner
  • Admin module edit view (backend)
    • System > Administrator Modules > Sample Data
  • Categories view of contact, content, newsfeeds (frontend w/o login)
    • /index.php?option=com_contact&view=categories
    • /index.php?option=com_content&view=categories
    • /index.php?option=com_newsfeeds&view=categories
  • Category view of contact, content, newsfeeds (frontend w/o login)
    • /index.php?option=com_contact&view=category&id=4
    • /index.php?option=com_content&view=category&id=2
    • /index.php?option=com_newsfeeds&view=category&id=5
      • ⚠️ Page contains a broken link to the /index.php/component/newsfeeds/newsfeed/first-news-feed?catid=5

Tested with this PR by graft Joomla_5.4.0-alpha4-dev+pr.45702-Development-Full_Package.zip:

  • ✅ Tested all the backend views, including editing
  • ✅ Tested all the frontend views, including the links in the views
  • ✅ The previous broken link is now working
avatar muhme muhme - change - 26 Jul 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-07-26 14:08:28
Closed_By muhme
avatar muhme muhme - close - 26 Jul 2025
avatar muhme muhme - merge - 26 Jul 2025
avatar muhme
muhme - comment - 26 Jul 2025

Thank you @heelc29 for your contribution and @Hackwar for your code review. Thank you @exlemor and @hans2103 for testing.

Add a Comment

Login with GitHub to post a comment