?

Success

Referenced as Not before: # 6462

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Oct 2014

Move modals from mootools to Bootstrap

this now serves only the styling and the image required in Hathor.

To test this you should go to: joomla-extensions/messages#7

Create an installable package and then apply also this PR!

avatar dgt41 dgt41 - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar dgt41 dgt41 - reference | - 12 Oct 14
avatar brianteeman brianteeman - change - 13 Oct 2014
Category Templates (admin) UI/UX
avatar dgt41 dgt41 - reference | - 14 Oct 14
avatar infograf768
infograf768 - comment - 14 Oct 2014

This PR contains unrelated stuff concerning banners

avatar dgt41
dgt41 - comment - 14 Oct 2014

@infograf768 That was a mistake, now PR should be safe

avatar dgt41 dgt41 - change - 14 Oct 2014
The description was changed
avatar phproberto
phproberto - comment - 14 Oct 2014

It seems that you added the CSS to the template.css files directly. You should work on the template.less files and then generate the css files.

You can do it from the build folder running:

cd build
php generatecss.php

And same for RTL changes

avatar infograf768
infograf768 - comment - 15 Oct 2014

@phproberto
As far as I could see, the PR used generatecss.
The changes in the css files comes from the changes in the
/media/jui/less/modals.joomla.less
and
media/jui/less/modals.less

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar suredweb
suredweb - comment - 17 Oct 2014

@test now It's been modal bootstrap but I got width of modal too large
joomla3-modal-bootstrap

avatar suredweb suredweb - test_item - 17 Oct 2014 - Tested successfully
avatar tairedweb tairedweb - test_item - 17 Oct 2014 - Tested successfully
avatar tairedweb
tairedweb - comment - 17 Oct 2014

@suscess


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4563.

avatar AnishaVora AnishaVora - test_item - 17 Oct 2014 - Not tested
avatar micker micker - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Needs Review
avatar dgt41
dgt41 - comment - 17 Oct 2014

@suredweb The width has been setup globally for all modals. We could override the width for this modal. But the question is: does it worth it?

avatar mtmeyrick mtmeyrick - test_item - 17 Oct 2014 - Tested successfully
avatar losedk
losedk - comment - 19 Oct 2014

All good. Are we able to place the buttons in the bottom like Bootstrap prescribe?

skaermbillede 2014-10-20 kl 00 21 20

avatar dgt41
dgt41 - comment - 19 Oct 2014

@losedk Nice idea, I also try to do that as it only requires to put this part that renders the buttons https://github.com/joomla/joomla-cms/pull/4563/files#diff-1caf6f6c420934f653cb344972c49abbR29 in the footer. The only problem is that in the current short-code for bootstrap modals in the toolbar this is not yet implemented: in current implementation the footer part doesn’t exist https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L46. I’ll make a PR for that, if it get’s accepted we can move them easily in the footer area! Thanks for bringing this up, I totally forgot it

avatar losedk
losedk - comment - 19 Oct 2014

@dgt41 Great. Just ping me, when you have something! :)

avatar dgt41 dgt41 - reference | - 6 Nov 14
avatar dgt41
dgt41 - comment - 6 Nov 2014

Hathor view:
screen shot 2014-11-06 at 10 22 27

avatar dgt41 dgt41 - reference | - 28 Dec 14
avatar dgt41 dgt41 - reference | - 28 Dec 14
avatar brianteeman brianteeman - change - 1 Jan 2015
Labels
avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 20 Jan 2015

Is this PR outdated - its hard to tell

avatar dgt41 dgt41 - reference | - 12 Mar 15
avatar dgt41 dgt41 - reference | - 12 Mar 15
avatar dgt41
dgt41 - comment - 12 Mar 2015

Can this considered RTC? @roland-d ?

avatar n9iels
n9iels - comment - 16 Mar 2015

@test works fine, but can you change the buttons like @losedk suggested a few messages above?

avatar dgt41
dgt41 - comment - 16 Mar 2015

@n9iels thanks for testing. As I already told @losedk this needs one more PR in order to make the toolbar button compatible with the footer option of bootstrap modals. I don’t want to make that here, as it will be too complicate for reviewers o follow the changes

avatar n9iels
n9iels - comment - 16 Mar 2015

I'm sorry, I didn't saw that :-) If this one is Merged and you have that PR, please post its number here so I can test that one to

@test Succesfull!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4563.
avatar n9iels n9iels - test_item - 16 Mar 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 16 Mar 2015

@losedk @n9iels In order to have the layout @losedk suggest #6462 needs to be merged!

avatar dgt41
dgt41 - comment - 24 Mar 2015

@roland-d can you RTC this?

avatar roland-d
roland-d - comment - 18 Apr 2015

@dgt41 This can't go to RTC as it is now, the modal is too wide as mentioned also by @suredweb . I don't think that is an improvement being so wide. Is it a problem to make it less wide?

avatar roland-d roland-d - change - 18 Apr 2015
Status Needs Review Pending
avatar dgt41
dgt41 - comment - 18 Apr 2015

@roland-d The thing is that right now the default width is 80% of the window (that’s global not only here), so the question is do we keep a global value of 80% as default and override it here or do we keep a narrow default value (width: 560px; was the bootstrap default) and override in modals that require more estate?

avatar roland-d
roland-d - comment - 18 Apr 2015

@dgt41 To answer your question, I think we should look at the modals in place. Which ones are more common? If we need the wide ones more than the narrow ones, we should set the wide value as default, otherwise the other way around. Based on that we will know if this modal should be overridden or not.

avatar dgt41
dgt41 - comment - 18 Apr 2015

@roland-d how about this:
screen shot 2015-04-18 at 10 35 41

needs only:

JFactory::getDocument()->addStyleDeclaration(
    "
    div.modal{
        width: 560px;
        margin-left: -280px;
    }
    "
);```
in /administrator/components/com_messages/views/messages/tmpl/default.php
and 
```php
$bar->appendButton('Popup', 'cog', 'COM_MESSAGES_TOOLBAR_MY_SETTINGS', 'index.php?option=com_messages&view=config&tmpl=component', '400px', '250px');

in /administrator/components/com_messages/views/messages/view.html.php

avatar dgt41
dgt41 - comment - 18 Apr 2015

We have these modals that need some serious width:
image (media field)
user (user field )
history (version field)
menuselect (menutype field)
module (modal to edit modules in menu)

and I am pretty sure I forget some more…

The only ones that fit better in narrow width are: this messages options and maybe multi language status

avatar roland-d
roland-d - comment - 28 Apr 2015

@dgt41 So we have more modals that need wide width than narrow width. That explains itself then, we use the wide width as standard and apply local changes where smaller width is needed.

Do you think this can be done by using a class?

avatar dgt41
dgt41 - comment - 18 May 2015

@roland-d Ok made some adjustments here:
width 500px
and inline script through API

screen shot 2015-05-19 at 12 22 15

avatar roland-d
roland-d - comment - 28 May 2015

@dgt41 Could you please sync the PR?

avatar dgt41
dgt41 - comment - 28 May 2015

@roland-d there you go. #jab15

avatar dgt41
dgt41 - comment - 30 May 2015

@n9iels @suredweb @tairedweb @losedk can anyone give it to test?
This should be the preview for the last iteration:
screenshot 2015-05-30 14 46 05

avatar losedk
losedk - comment - 30 May 2015

@dgt41 Sure. Give me a minute

avatar losedk
losedk - comment - 30 May 2015

@dgt41 Issues:

Responsive:

skaermbillede 2015-05-30 kl 15 31 43

Hidden tooltip on the first label (possibly not the only place then):

skaermbillede 2015-05-30 kl 15 32 47

Large button:

skaermbillede 2015-05-30 kl 15 33 10

The success button is inheriting the large width from the toolbar. Perhaps we should change this globally so the button isn't so big in the modals?

Hathor:

Missing an icon
skaermbillede 2015-05-30 kl 15 34 55

avatar dgt41
dgt41 - comment - 30 May 2015

@losedk Thanks, I just fixed the mobile weird behavior. About Hathor there is <span class="icon-32-cog"></span> which should load the icon but obviously the icon doesn’t exist and I am not the best bet to design an icon

avatar losedk
losedk - comment - 30 May 2015

@dgt41 What about?

skaermbillede 2015-05-30 kl 18 10 18

avatar dgt41
dgt41 - comment - 30 May 2015

@losedk where can i find that button (i mean which view)?

avatar dgt41
dgt41 - comment - 30 May 2015

@losedk I manage to do it! please retest?

avatar losedk
losedk - comment - 30 May 2015

Could you add it to the stylesheet instead?

avatar dgt41
dgt41 - comment - 30 May 2015

Done!

avatar losedk
losedk - comment - 31 May 2015

@dgt41 All good now!

avatar zero-24 zero-24 - reference | 719823a - 2 Jun 15
avatar dgt41
dgt41 - comment - 2 Jun 2015

Moved here

avatar dgt41 dgt41 - change - 2 Jun 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-06-02 17:36:25
Closed_By dgt41
avatar dgt41 dgt41 - close - 2 Jun 2015
avatar dgt41 dgt41 - close - 2 Jun 2015
avatar zero-24
zero-24 - comment - 2 Jun 2015

@dgt41 we need the CSS / hathor stuff still in the core :smile:

avatar zero-24 zero-24 - change - 2 Jun 2015
Status Closed New
Closed_Date 2015-06-02 17:36:25
Closed_By dgt41
avatar zero-24 zero-24 - reopen - 2 Jun 2015
avatar zero-24 zero-24 - reopen - 2 Jun 2015
avatar zero-24
zero-24 - comment - 2 Jun 2015

Can you just remove the messages part and let the css / hathor stuff there?

avatar dgt41
dgt41 - comment - 2 Jun 2015
avatar dgt41 dgt41 - change - 2 Jun 2015
The description was changed
avatar zero-24
zero-24 - comment - 2 Jun 2015

Thanks @dgt41 I'm going to move this now to RTC :+1:

avatar zero-24 zero-24 - change - 2 Jun 2015
Status New Ready to Commit
avatar zero-24 zero-24 - change - 2 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 2 Jun 2015
Labels Added: ?
avatar roland-d roland-d - change - 9 Jun 2015
Title
Messages modal cornverted to Bootstrap
Messages modal converted to Bootstrap
avatar zero-24
zero-24 - comment - 30 Jun 2015

As it is planned to remove messages with 3.5 (http://developer.joomla.org/news/616-meeting-notes-from-jab-plt-summit-2015.html) We need this here and also joomla-extensions/messages#7 to fix the issue :smile:

avatar Kubik-Rubik
Kubik-Rubik - comment - 12 Jul 2015

Thank you @dgt41! Merged in the 3.5-dev branch (fa39ddc).

avatar Kubik-Rubik Kubik-Rubik - change - 12 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-12 19:58:05
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 12 Jul 2015
avatar zero-24 zero-24 - close - 12 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment