This PR contains unrelated stuff concerning banners

@infograf768 That was a mistake, now PR should be safe

It seems that you added the CSS to the template.css files directly. You should work on the template.less files and then generate the css files.

You can do it from the build folder running:

cd build
php generatecss.php

And same for RTL changes

@phproberto
As far as I could see, the PR used generatecss.
The changes in the css files comes from the changes in the
/media/jui/less/modals.joomla.less
and
media/jui/less/modals.less

@test now It's been modal bootstrap but I got width of modal too large

@suscess


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4563.

@suredweb The width has been setup globally for all modals. We could override the width for this modal. But the question is: does it worth it?

All good. Are we able to place the buttons in the bottom like Bootstrap prescribe?

@losedk Nice idea, I also try to do that as it only requires to put this part that renders the buttons https://github.com/joomla/joomla-cms/pull/4563/files#diff-1caf6f6c420934f653cb344972c49abbR29 in the footer. The only problem is that in the current short-code for bootstrap modals in the toolbar this is not yet implemented: in current implementation the footer part doesn’t exist https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L46. I’ll make a PR for that, if it get’s accepted we can move them easily in the footer area! Thanks for bringing this up, I totally forgot it

@dgt41 Great. Just ping me, when you have something! :)

Hathor view:

Is this PR outdated - its hard to tell

Can this considered RTC? @roland-d ?

@test works fine, but can you change the buttons like @losedk suggested a few messages above?

@n9iels thanks for testing. As I already told @losedk this needs one more PR in order to make the toolbar button compatible with the footer option of bootstrap modals. I don’t want to make that here, as it will be too complicate for reviewers o follow the changes

I'm sorry, I didn't saw that :-) If this one is Merged and you have that PR, please post its number here so I can test that one to

@test Succesfull!

@losedk @n9iels In order to have the layout @losedk suggest #6462 needs to be merged!

@roland-d can you RTC this?

@dgt41 This can't go to RTC as it is now, the modal is too wide as mentioned also by @suredweb . I don't think that is an improvement being so wide. Is it a problem to make it less wide?

@roland-d The thing is that right now the default width is 80% of the window (that’s global not only here), so the question is do we keep a global value of 80% as default and override it here or do we keep a narrow default value (width: 560px; was the bootstrap default) and override in modals that require more estate?

@dgt41 To answer your question, I think we should look at the modals in place. Which ones are more common? If we need the wide ones more than the narrow ones, we should set the wide value as default, otherwise the other way around. Based on that we will know if this modal should be overridden or not.

@roland-d how about this:

needs only:

JFactory::getDocument()->addStyleDeclaration(
    "
    div.modal{
        width: 560px;
        margin-left: -280px;
    }
    "
);```
in /administrator/components/com_messages/views/messages/tmpl/default.php
and 
```php
$bar->appendButton('Popup', 'cog', 'COM_MESSAGES_TOOLBAR_MY_SETTINGS', 'index.php?option=com_messages&view=config&tmpl=component', '400px', '250px');

in /administrator/components/com_messages/views/messages/view.html.php

We have these modals that need some serious width:
image (media field)
user (user field )
history (version field)
menuselect (menutype field)
module (modal to edit modules in menu)

and I am pretty sure I forget some more…

The only ones that fit better in narrow width are: this messages options and maybe multi language status

@dgt41 So we have more modals that need wide width than narrow width. That explains itself then, we use the wide width as standard and apply local changes where smaller width is needed.

Do you think this can be done by using a class?

@roland-d Ok made some adjustments here:
width 500px
and inline script through API

@dgt41 Could you please sync the PR?

@roland-d there you go. #jab15

@n9iels @suredweb @tairedweb @losedk can anyone give it to test?
This should be the preview for the last iteration:

@dgt41 Sure. Give me a minute

@dgt41 Issues:

Responsive:

Hidden tooltip on the first label (possibly not the only place then):

Large button:

The success button is inheriting the large width from the toolbar. Perhaps we should change this globally so the button isn't so big in the modals?

Hathor:

Missing an icon

@losedk Thanks, I just fixed the mobile weird behavior. About Hathor there is <span class="icon-32-cog"></span> which should load the icon but obviously the icon doesn’t exist and I am not the best bet to design an icon

@dgt41 What about?

@losedk where can i find that button (i mean which view)?

@losedk I manage to do it! please retest?

Could you add it to the stylesheet instead?

Done!

@dgt41 All good now!

Moved here

@dgt41 we need the CSS / hathor stuff still in the core

Can you just remove the messages part and let the css / hathor stuff there?

@zero-24 ok

Thanks @dgt41 I'm going to move this now to RTC

As it is planned to remove messages with 3.5 (http://developer.joomla.org/news/616-meeting-notes-from-jab-plt-summit-2015.html) We need this here and also joomla-extensions/messages#7 to fix the issue

Thank you @dgt41! Merged in the 3.5-dev branch (fa39ddc).