Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4562] - Move modals to Bootstrap

?

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Oct 2014

Move modals from mootools to Bootstrap

This is the last (I hope) PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561.

Testing:

Apply patch and follow the images below to see where you should focus:

administrator/index.php?option=com_menus&view=menus
screenshot 2014-10-12 06 35 39

screenshot 2014-10-12 06 35 53

administrator/index.php?option=com_menus&view=item&layout=edit&id=101
screenshot 2014-10-12 06 36 12
screenshot 2014-10-12 06 36 24

screenshot 2014-10-12 06 36 36
screenshot 2014-10-12 06 36 46
———————

avatar dgt41 dgt41 - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar Fedik
Fedik - comment - 12 Oct 2014

@dgt41 you mixed here a two pull request, for remove mootools from editing page, and replace the old modal to bootstrap.modal ...

problem that you copy #4517 partially ... I think, maybe you need or do a whole copy (and I will close old), or do separately

avatar dgt41
dgt41 - comment - 12 Oct 2014

I will revert the js part on my PR, so leave this PR open.

avatar dgt41
dgt41 - comment - 12 Oct 2014

Reuse a language string for Menu Item Type:
screenshot 2014-10-12 20 10 22

avatar brianteeman brianteeman - change - 13 Oct 2014
Category ⇒ Templates (admin) UI/UX
avatar dgt41 dgt41 - close - 13 Oct 2014
avatar dgt41 dgt41 - change - 13 Oct 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-13 20:15:51
avatar Bakual
Bakual - comment - 13 Oct 2014

You apparently rebased the wrong way around. You added the commits from staging after your own commits instead of replaying them on top of them.
I did that several times until I figured out how to do it correctly :smile:

avatar dgt41
dgt41 - comment - 13 Oct 2014

Now I know

Add a Comment

Login with GitHub to post a comment