Feeling Lucky
?
[#6462] - Allow toolbar popup buttons use bootstrap footer
- Closed
- 28 May 2015
- Medium
- Build: staging
- Easy Test
- # 6462
- Diff
- dgt41:_bs_footer_for_toolbar_btn
- Success The Travis CI build passed Details
Not before
# 4563
User tests: Successful: Unsuccessful:
Allow custom footer on BS modals rendered from toolbar button
This is a new feature requested at #4563
What it does?
Allows to render modal in the bootstrap official way, where the buttons are on the bottom of the modal window
How to test
Apply this patch and #4563
Change line 83 of administrator/components/com_messages/views/messages/view.html.php to
$bar->appendButton('Popup', 'cog', 'COM_MESSAGES_TOOLBAR_MY_SETTINGS', 'index.php?option=com_messages&view=config&tmpl=component', 600, 250, 0, 0, '', '', '<a href="#" class="btn">Close</a> <a href="#" class="btn btn-primary">Save changes</a>');You should get:
Mind that the buttons are fake, no functionality is attached
joomla-cms-bot
- | Labels |
Added:
?
|
||
losedk
- comment
- 16 Mar 2015
Just tested it. It works fine!
| Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
losedk
- comment
- 21 Mar 2015
Should we move this RTC? Two good tests
| Rel_Number | 0 | ⇒ | 4563 |
| Relation Type | ⇒ | Not before |
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 25 May 2015
Thanks for the bump 
RTC now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6462.
| Labels |
Added:
?
|
||
zero-24
- comment
- 25 May 2015
@committer please be sure that #4563 is merged bevor this as this is a requirement.
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-28 23:31:54 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@test Looks good on desktop, on mobile layout the buttons fall over each other